Upgrade Leanplum SDK from 3.0.2 to 4.2.7
Categories
(Firefox for Android Graveyard :: General, task, P1)
Tracking
(firefox-esr60 wontfix, firefox-esr68 fixed, firefox68 wontfix, firefox69 fixed, firefox70 fixed)
People
(Reporter: andrei.a.lazar, Assigned: andrei.a.lazar)
References
Details
(Whiteboard: [fennec68.1])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Bug 1509525 has a patch to update Fennec to Leanplum SDK 4.2.1. The patch is seven months old and for an older SDK version (4.2.1, not 4.2.7), so it is probably not useful now. I'll close that bug as a dupe of this bug.
Jeff Boek (who integrated Leanplum and Fenix) warned that Fennec's current copy of the Leanplum SDK has been modified. We should check what local changes we've made and whether we need to reapply those changes to SDK version 4.2.7!
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
Confirmed with Andrei that this is ready to be merged.
Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49adaf24b578
Upgrade Leanplum SDK from 3.0.2 to 4.2.7 r=petru
Comment 6•5 years ago
|
||
bugherder |
Assignee | ||
Comment 7•5 years ago
|
||
Comment on attachment 9079369 [details]
Bug 1566406 Upgrade Leanplum SDK from 3.0.2 to 4.2.7 r=petru
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: We can benefit from most of the latest fixes and new features of Leanplum.
- User impact if declined: We may still encounter some issues that have been fixed long time ago in the official repo.
- Fix Landed on Version:
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The code is taken from the official repository of Leanplum (see https://github.com/Leanplum/Leanplum-Android-SDK/tree/4.2.7)
- String or UUID changes made by this patch:
Comment 8•5 years ago
|
||
Comment on attachment 9079369 [details]
Bug 1566406 Upgrade Leanplum SDK from 3.0.2 to 4.2.7 r=petru
Updates our Leanplum SDK to something more modern. With any luck it'll help the ARM64 reporting issues too. Approved for Fennec 68.1b5 (and will be in tomorrow's Nightly builds if we want to start looking for any changes in reporting).
Comment 9•5 years ago
|
||
bugherder uplift |
Comment 10•5 years ago
|
||
bugherder uplift |
Updated•5 years ago
|
Updated•3 years ago
|
Description
•