Closed Bug 1566434 Opened 6 months ago Closed 6 months ago

Assert there's a unique entry for pc + kind in BaselineScript::retAddrEntryFromPCOffset

Categories

(Core :: JavaScript Engine: JIT, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(2 files)

We really don't want to find duplicates there and should assert against this.

Flags: needinfo?(jdemooij)

Actually it's probably simpler and better to assert this in the compiler; the sooner we fail the better.

This is nicer and will make it easier to assert RetAddrEntry invariants in
appendRetAddrEntry in the next patch.

(In reply to Jan de Mooij [:jandem] from comment #1)

Actually it's probably simpler and better to assert this in the compiler; the sooner we fail the better.

While biking last night it occurred to me this doesn't work because the invariant only holds for the callVMs (or bytecode ops) that can trigger DebugOSR. Oh well.

Flags: needinfo?(jdemooij)
Priority: -- → P1
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdb913e6361e
part 1 - Remove markLastRetAddrKind in BaselineCodeGen, use the correct Kind from the start. r=iain
https://hg.mozilla.org/integration/autoland/rev/08fa2abfae88
part 2 - Add more RetAddrEntry assertions. r=iain
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.