Closed
Bug 1566435
Opened 5 years ago
Closed 5 years ago
Make the network monitor destruction codepath synchronous
Categories
(DevTools :: Netmonitor, enhancement, P3)
DevTools
Netmonitor
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(2 files)
See bug 1529621. This bug is dedicated to the Network monitor and aims at getting rid of async on this particular method and all its dependencies:
https://searchfox.org/mozilla-central/rev/07f7390618692fa4f2a674a96b9b677df3a13450/devtools/client/netmonitor/panel.js#32-36
|
||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
There is no guarantee that any RDP request will be completed when the toolbox
closes, so that we should do the cleanup from the actor side if anything
needs to be stopped or removed.
|
|
Assignee | |
Comment 3•5 years ago
|
||
It looks like it just works and no test are failing:
https://treeherder.mozilla.org/#/jobs?repo=try&author=apoirot%40mozilla.com&selectedJob=256951052
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb91c01b8bdb Make netmonitor destroy codepath synchronous. r=Honza https://hg.mozilla.org/integration/autoland/rev/03bb034db3d6 Stop emitting requests when the netmonitor closes. r=Honza
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fb91c01b8bdb
https://hg.mozilla.org/mozilla-central/rev/03bb034db3d6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•