Closed Bug 1566467 Opened 5 years ago Closed 5 years ago

Speed up shared/node-attribute-parser getType function

Categories

(DevTools :: Inspector: Rules, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

We can speed up the getType function by changing the dataType into an object from an array. That way we avoid looping looking for the matching tagName and namespaceURI and access the typeData directly by their tagName.

We can speed up the getType function by changing the dataType into an object from an array.
That way we avoid looping looking for the matching tagName and namespaceURI and access the typeData directly by their tagName.

Notable:
cold.inspector.open.DAMP -0.33%
complicated.inspector.open.DAMP -0.38%
custom.inspector.open.DAMP -0.74%

Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6d154b23098
Speed up shared/node-attribute-parser getType function. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: