1566467 - Speed up shared/node-attribute-parser getType function

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We can speed up the getType function by changing the dataType into an object from an array. That way we avoid looping looking for the matching tagName and namespaceURI and access the typeData directly by their tagName.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1566467 - Speed up shared/node-attribute-parser getType function. r=nchevobbe

We can speed up the getType function by changing the dataType into an object from an array.
That way we avoid looping looking for the matching tagName and namespaceURI and access the typeData directly by their tagName.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

DAMP https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=18da9ca8e49f7d6a77dfdbad68645ee38db18f5d&originalSignature=1759151&newSignature=1759151&framework=12&originalRevision=0db3171f2f30b7af43af09a7fbf265285c151cf2
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=18da9ca8e49f7d6a77dfdbad68645ee38db18f5d

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Notable:
cold.inspector.open.DAMP -0.33%
complicated.inspector.open.DAMP -0.38%
custom.inspector.open.DAMP -0.74%

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6d154b23098
Speed up shared/node-attribute-parser getType function. r=nchevobbe

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b6d154b23098