Return a GeckoResult from GeckoProcessManager::Start
Categories
(Core :: IPC, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(4 files)
This allows us to push the asynchronicity down into the Java layer, where we'll eventually use it to get rid of some synchronous waiting during process launch.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
This paves the way for us to use a dispatcher other than mDispatcher,
which will be useful in the MozPromise integration in the coming
patches.
|
|
Assignee | |
Comment 6•5 years ago
|
||
Here's a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ec2f694424dc9f77d2619ad1bc82ef4f0e5a3a8&selectedJob=257974870
Looks like there's one failure:
TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.GeckoResultTest.then_propagatedUncaughtException | status -2
I'll look when I get a chance. Feel free to review in the mean time though.
|
||
Updated•5 years ago
|
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92f3b1bb34a4 Factor primitive conversion logic out of EventDispatcher. r=snorp https://hg.mozilla.org/integration/autoland/rev/14ea9c84bb0e Generalize GeckoResult.mHandler to a Dispatcher interface. r=snorp https://hg.mozilla.org/integration/autoland/rev/fbc829be6c4f Associate each GeckoResult listener with an explicit dispatcher. r=snorp https://hg.mozilla.org/integration/autoland/rev/3700ef585384 Bridge GeckoResult to MozPromise and return a GeckoResult from GeckoProcessManager::start. r=snorp
|
||
Comment 8•5 years ago
|
||
Backed out 4 changesets (bug 1566583) for apilint and checkstyle failure at geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java
Backout: https://hg.mozilla.org/integration/autoland/rev/151616d86efd9be560b928f599292456837010f9
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=3700ef585384df96e35b44c6888b860347e68db1
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258165184&repo=autoland&lineNumber=2945
task 2019-07-24T19:53:45.193Z] 19:53:45 INFO - Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
[task 2019-07-24T19:53:45.194Z] 19:53:45 INFO - /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java:40: error: cannot find symbol
[task 2019-07-24T19:53:45.194Z] 19:53:45 INFO - import org.mozilla.geckoview.R;
[task 2019-07-24T19:53:45.194Z] 19:53:45 INFO - ^
[task 2019-07-24T19:53:45.194Z] 19:53:45 INFO - symbol: class R
[task 2019-07-24T19:53:45.194Z] 19:53:45 INFO - location: package org.mozilla.geckoview
[task 2019-07-24T19:53:45.194Z] 19:53:45 INFO - 1 warning
[task 2019-07-24T19:53:45.393Z] 19:53:45 INFO - > Task :geckoview:apiLintSingleWithGeckoBinariesDebug
[task 2019-07-24T19:53:45.693Z] 19:53:45 INFO - > Task :geckoview:apiCompatLintWithGeckoBinariesDebug FAILED
[task 2019-07-24T19:53:45.693Z] 19:53:45 INFO - API style issues
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - Warning L1: Registration methods should have overload that accepts delivery Executor
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in method public void nativeThen(GeckoResult.GeckoCallback, GeckoResult.GeckoCallback)
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in @AnyThread public class GeckoResult<T>
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in package org.mozilla.geckoview
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - at line 253
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - Error GV5: Missing argument type nullability annotation. Needs one of @Nullable, @NonNull.
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in org.mozilla.geckoview.GeckoResult.GeckoCallback
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in method public void nativeThen(GeckoResult.GeckoCallback, GeckoResult.GeckoCallback)
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in @AnyThread public class GeckoResult<T>
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - in package org.mozilla.geckoview
[task 2019-07-24T19:53:45.694Z] 19:53:45 INFO - at line 253
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/388e7bb0eb07 Factor primitive conversion logic out of EventDispatcher. r=snorp https://hg.mozilla.org/integration/autoland/rev/7f1980e72618 Generalize GeckoResult.mHandler to a Dispatcher interface. r=snorp https://hg.mozilla.org/integration/autoland/rev/88f41dcfdd9a Associate each GeckoResult listener with an explicit dispatcher. r=snorp https://hg.mozilla.org/integration/autoland/rev/80c361bdcb3d Bridge GeckoResult to MozPromise and return a GeckoResult from GeckoProcessManager::start. r=snorp
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/388e7bb0eb07
https://hg.mozilla.org/mozilla-central/rev/7f1980e72618
https://hg.mozilla.org/mozilla-central/rev/88f41dcfdd9a
https://hg.mozilla.org/mozilla-central/rev/80c361bdcb3d
Description
•