[wpt-sync] Sync PR 17869 - Create an attribute and property for toast closebutton and attach close functionality
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 17869 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/17869
Details from upstream follow.
Jack Steinberg <jacksteinberg@chromium.org> wrote:
Create an attribute and property for toast closebutton and attach close functionality
This change sets the groundwork for the toast closebutton, by
adding an attribute to set the closebutton content,
creating a closeButton property to reflect that attribute,
and adding an event listener to close the toast when the closebutton is pressed.Future CLs will add the closeButton option for showToast
(https://github.com/jackbsteinberg/std-toast/tree/master#showtoastmessage-options).Bug:972945
Change-Id: I5d6c3055791a9f93ef414e575e128c61e2a944ed
Reviewed-on: https://chromium-review.googlesource.com/1699269
WPT-Export-Revision: 0d1c9506bd5f5fcab27195227f5ba455bedf14d7
Assignee | ||
Comment 1•5 years ago
|
||
PR 17869 applied with additional changes from upstream: 17de974a80b0d9a6ff48dc24796441057afad5a0, ad56cbc9ec5c81cfba969b66f04a9b0c4469056e, acbc0cf6a6101f953f838cd02fe001bf08503d3d
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba5d0c39eb300a2b762506d8f5bf8f5070bff9b3
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1500eafdcf131250b35f7de3c52e407cdc9c796d
Assignee | ||
Comment 4•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4477e6d6e2a44c92a3ed83f7e62fd8b3bcce50c5
Assignee | ||
Comment 5•5 years ago
|
||
Ran 2 tests TIMEOUT: 2 New tests that have failures or other problems: /std-toast/attributes.html: TIMEOUT /std-toast/closebutton.html: TIMEOUT
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/8930d78b9176 [wpt PR 17869] - Create an attribute and property for toast closebutton and attach close functionality, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/b76114b14c20 [wpt PR 17869] - Update wpt metadata, a=testonly
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8930d78b9176
https://hg.mozilla.org/mozilla-central/rev/b76114b14c20
Description
•