1566700 - Expose xattr checking and setting functionality

Status: RESOLVED FIXED

(Toolkit :: OS.File, enhancement, P1)

Description

[Bryce Seager van Dyk (:bryce)]

It would be useful to be able to check and set extended attributes/xattrs to address bug 1566523 (which is Mac specific). Beyond that bug such functionality seems like it may have a wider general use.

I believe this functionality would be specific to the Unix part of the lib, as I'm not sure Windows has a suitable analog.

Comment 1

[Bryce Seager van Dyk (:bryce)]

Marking P1 since we want this functionality in 70 because of dependent bugs.

Bug 1566523 only requires the ability to remove an xattr, but adding the setting a checking functionality seems necessary for sane testing.

I've got a first draft of the removal piece that I will push to review shortly as I want to start iterating on feedback as I'm new to this area of the codebase. To be clear: I intend to follow up that patch with further functionality and tests and will not land that patch alone.

Comment 2

[Bryce Seager van Dyk (:bryce)]

Attachment: Bug 1566700 - Add File.OS macRemoveXAttr. r?yoric!

Add functionality to remove an extended attribute from a file. This
functionality is currently MacOS specific due to that being the only use case we
currently have (see bug 1566523).

Comment 3

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4af7c52252caa460417714985769d26d97da31e4

Comment 4

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2c703a47354c95ddb10c40861e137b95565a146

Comment 5

[Bryce Seager van Dyk (:bryce)]

Attachment: Bug 1566700 - Add functions to OS.File to set and get extended attributes on MacOS. r?yoric!

Depends on D38523

Comment 6

[Bryce Seager van Dyk (:bryce)]

Attachment: Bug 1566700 - Add tests for OS.File extended attribute MacOS functions. r?yoric!

Depends on D38964

Comment 7

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4797a3884afe22c80fd82260687652f4af82417c

Comment 8

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5db134394e48749637c94de02505816f27ee789

Comment 9

[Bryce Seager van Dyk (:bryce)]

[Tracking Requested - why for this release]: This bug will be required to have EME work on MacOS Catalina (it blocks bug 1566523 which in turn blocks our ability to use the CDM). Users are already encountering this is the Catalina beta and I would like to uplift if possible so the fix is available sooner.

Comment 10

[Bryce Seager van Dyk (:bryce)]

[Tracking Requested - why for this release]: Please see comment 9.

Comment 11

[Bryce Seager van Dyk (:bryce)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d639153969422ee456ad0a30ec2e501cd360fe3

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ad6a2f6b8c7
Add File.OS macRemoveXAttr. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/a72f3a07f505
Add functions to OS.File to set and get extended attributes on MacOS. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/45483fab866c
Add tests for OS.File extended attribute MacOS functions. r=Yoric

Comment 13

[Andrei Ciure[:andrei_ciure]]

https://hg.mozilla.org/mozilla-central/rev/8ad6a2f6b8c7
https://hg.mozilla.org/mozilla-central/rev/a72f3a07f505
https://hg.mozilla.org/mozilla-central/rev/45483fab866c

Comment 14

[Bryce Seager van Dyk (:bryce)]

Comment on attachment 9079091 [details]
Bug 1566700 - Add File.OS macRemoveXAttr. r?yoric!

Beta/Release Uplift Approval Request

• User impact if declined: Playback of premium video will not work under MacOS Catalina due to the CDM being blocked by new security features. These changes are needed to remove quarantine from the Widevine CDM once we extract it. If we do not do this loading of the CDM will be blocked by the OS.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1566523, Bug 1558924, Bug 1566180
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patches adds new functionality which is only currently used by bugs in this bug's dependency chain. Uplift of just these patches alone is essentially a no-op. I will note the risks of the other bugs in the chain on their respective uplift requests.
• String changes made/needed: None.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Bustage of premium video playback on MacOS Catalina. We expect Catalina will release near the end of September, thought this date is not confirmed.
• User impact if declined: Playback of premium video will not work under MacOS Catalina due to the CDM being blocked by new security features. These changes are needed to remove quarantine from the Widevine CDM once we extract it. If we do not do this loading of the CDM will be blocked by the OS.
• Fix Landed on Version: 70
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patches adds new functionality which is only currently used by bugs in this bug's dependency chain. Uplift of just these patches alone is essentially a no-op. I will note the risks of the other bugs in the chain on their respective uplift requests.
• String or UUID changes made by this patch: None.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9079091 [details]
Bug 1566700 - Add File.OS macRemoveXAttr. r?yoric!

Fixes for encrypted video playback for macOS 10.15. Approved for 69.0b10.

Comment 16

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5aa01b3fc6f4
https://hg.mozilla.org/releases/mozilla-beta/rev/e0410893938a
https://hg.mozilla.org/releases/mozilla-beta/rev/252d1331b768

Comment 17

[Julien Cristau [:jcristau]]

Comment on attachment 9079091 [details]
Bug 1566700 - Add File.OS macRemoveXAttr. r?yoric!

necessary change for macos 10.15 support, approved for 68.1 and 60.9

Comment 18

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/0e1f9c52cff0
https://hg.mozilla.org/releases/mozilla-esr68/rev/9465a474f587
https://hg.mozilla.org/releases/mozilla-esr68/rev/ea19540ddf1a

Comment 19

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Skipped during esr60 uplifts for conflicts.

Comment 20

[Bryce Seager van Dyk (:bryce)]

Try push with patches hand applied for ESR60: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb1c01a1745497254582a87e29db139db8e8c768

Comment 21

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/44c6365ee67b
https://hg.mozilla.org/releases/mozilla-esr60/rev/47a6a95c6f12
https://hg.mozilla.org/releases/mozilla-esr60/rev/80d79fc1f90e