Closed Bug 1566763 Opened 1 year ago Closed 1 year ago

Review DEVTOOLS_ABOUTDEBUGGING_OPENED_COUNT after removing old aboutdebugging

Categories

(DevTools :: about:debugging, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The old aboutdebugging used to record the opened_counts in the following histogram: DEVTOOLS_ABOUTDEBUGGING_OPENED_COUNT

This was recorded via the following code:
https://searchfox.org/mozilla-central/rev/22b330ecb3edba1536a54887060cbdd09db21c59/devtools/client/aboutdebugging/components/Aboutdebugging.js#89

  componentDidMount() {
    window.addEventListener("hashchange", this.onHashChange);

    // aboutdebugging is not connected with a toolbox so we pass -1 as the
    // toolbox session id.
    this.props.telemetry.toolOpened("aboutdebugging", -1, this);
  }

The new aboutdebugging however only uses events for telemetry. The most similar event here would be dt_adbg - open_adbg.

We are removing the old aboutdebugging in https://bugzilla.mozilla.org/show_bug.cgi?id=1539461 so we should decide either to remove the probe or to call toolOpened for the new aboutdebugging (maybe we want to keep the histogram to easily compare with other devtools UIs which rely on toolOpened?)

Hi Harald

More telemetry questions! :)
This histogram used to record old aboutdebugging open counts. Do we want to keep it and use it from the new aboutdebugging, or do we feel like the events are enough now?

Flags: needinfo?(hkirschner)

It would be interesting to see if we regress, and making sure we validate the event telemetry numbers with the histogram as comparison – at least until we have confidence. Does that make sense or am I missing something?

What's the work in collecting the same telemetry for the new about:debugging?

Flags: needinfo?(hkirschner)

It is interesting

(In reply to :Harald Kirschner :digitarald from comment #2)

It would be interesting to see if we regress, and making sure we validate the event telemetry numbers with the histogram as comparison – at least until we have confidence. Does that make sense or am I missing something?

That sounds good, I also think it will be easier to compare.

What's the work in collecting the same telemetry for the new about:debugging?

Should be pretty easy, we just have to call telemetry.toolOpened("aboutdebugging", -1, this); when opening the new about:debugging.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92064bff2df5
Call telemetry.toolOpened/Closed from new aboutdebugging r=remote-debugging-reviewers,Ola
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.