1566785 - Port bug 1565051: Enable 'browser.in-content.dark-mode' by default

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Firefox enabled the in-content pages dark mode now officially. We can or should follow.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1566785-enable-in-content-dark-mode.patch

We normally use the toolkit common CSS and our adaptions in preferences page should be complete to enable it by default.

Comment 2

[Alessandro Castellani [:aleca]]

How do I test this?
Is enabling the dark theme enough or do I have to change the global OS settings?
Which sections should adapt to this settings? The Preferences? Message Compose? Others?

Comment 3

[Richard Marti (:Paenglab)]

Select the dark OS theme. The dark TB theme should be set but this pref affects all in-content pages like prefs, add-ons, troubleshooting page etc. Be sure you don't have set ui.systemUsesDarkTheme.

Comment 4

[Alessandro Castellani [:aleca]]

This doesn't seem to work for me.

I'm on macOS 10.14.5
OS Dark Mode is enabled
TB Dark Theme is enabled

Preferences, Add-ons, troubleshooting page, etc, are all light and don't adapt to the dark theme.
Where is ui.systemUsesDarkTheme located? In the Config Editor? I can't seem to find it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7dcf8290b483
Port bug 1565051: Enable 'browser.in-content.dark-mode' by default. r=aleca