Closed Bug 1566785 Opened 2 years ago Closed 2 years ago

Port bug 1565051: Enable 'browser.in-content.dark-mode' by default

Categories

(Thunderbird :: Theme, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Firefox enabled the in-content pages dark mode now officially. We can or should follow.

We normally use the toolkit common CSS and our adaptions in preferences page should be complete to enable it by default.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9078659 - Flags: review?(alessandro)

How do I test this?
Is enabling the dark theme enough or do I have to change the global OS settings?
Which sections should adapt to this settings? The Preferences? Message Compose? Others?

Select the dark OS theme. The dark TB theme should be set but this pref affects all in-content pages like prefs, add-ons, troubleshooting page etc. Be sure you don't have set ui.systemUsesDarkTheme.

This doesn't seem to work for me.

I'm on macOS 10.14.5
OS Dark Mode is enabled
TB Dark Theme is enabled

Preferences, Add-ons, troubleshooting page, etc, are all light and don't adapt to the dark theme.
Where is ui.systemUsesDarkTheme located? In the Config Editor? I can't seem to find it.

Attachment #9078659 - Flags: review?(alessandro) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7dcf8290b483
Port bug 1565051: Enable 'browser.in-content.dark-mode' by default. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.