1566903 - cmd+f should re-select the searchbar query

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

I've noticed that in editors cmd+f will always re-focus and select the searchbar text. This is useful when you're jumping between search results and want to quickly make changes in the searchbar. It is also a common convention that we should maintain.

Comment 1

[Kevin Morehouse]

I'd like to take this one, Jason.

Comment 3

[Kevin Morehouse]

Jason, I'd like to zero-in on an accurate STR for this bug. Is the following one correct?

Steps to Reproduce:

1. Navigate to http://todomvc.com/examples/backbone/
2. Open the debugger
3. Click the file todomvc.com/examples/backbone/js/collections/todos.js under the Sources tab in the left sidebar
4. Hit Cmd + F (or Ctrl+F on Windows)
5. Type "collection"
6. Hit Cmd + F (or Ctrl+F on Windows).

Expected Result:

• The query "collection" in the search bar should now be highlighted.

Actual Result:

• The query "collection" in the search bar is not highlighted.

Comment 4

[Jason Laster [:jlast]]

yep

Comment 5

[Kevin Morehouse]

Attachment: Bug 1566903 - Work-in-Progress Patch - Ensure that Ctrl/Cmd + F shortcut always re-selects the search bar query. r=jlast

This patch ensures that any existing query text in the search bar is highlighted when the Cmd/Ctrl + F shortcut is used.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af933062446a
Work-in-Progress Patch - Ensure that Ctrl/Cmd + F shortcut always re-selects the search bar query. r=jlast

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/af933062446a