Closed
Bug 1566911
Opened 5 years ago
Closed 5 years ago
Privacy & Security Preferences: right align certificates buttons
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: aleca, Assigned: Paenglab)
Details
Attachments
(1 file)
3.59 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
In the Privacy & Security
> Certificates
section, the 2 buttons should be right aligned like we're doing for every button in this new Preferences UI.
Align the "Manage Certificates" button to the right, on the same line of the "Query OCSP responder..." string.
Align the "Security Devices" button to right, underneath the "Manage Certificates" button.
Assignee | ||
Comment 1•5 years ago
|
||
This is a port of the FX solution. Because I was on it, I added the …
to the text in the buttons like FX has.
Attachment #9079089 -
Flags: review?(alessandro)
Reporter | ||
Comment 2•5 years ago
|
||
Comment on attachment 9079089 [details] [diff] [review] 1566911-align-certificates-buttons.patch Review of attachment 9079089 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. ::: mail/locales/en-US/chrome/messenger/preferences/advanced.dtd @@ +119,5 @@ > > +<!ENTITY manageCertificates2.label "Manage Certificates…"> > +<!ENTITY manageCertificates2.accesskey "M"> > +<!ENTITY viewSecurityDevices2.label "Security Devices…"> > +<!ENTITY viewSecurityDevices2.accesskey "D"> Are we allowed to change strings at this stage?
Attachment #9079089 -
Flags: review?(alessandro) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/607388043035
Privacy & Security Preferences: right align certificates buttons. r=aleca
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 70.0
You need to log in
before you can comment on or make changes to this bug.
Description
•