1566925 - generic-worker: change command in docker_posix task payload to match docker-worker

Status: RESOLVED FIXED

(Taskcluster :: Workers, enhancement)

Description

[Miles Crabill [:miles]]

docker-worker accepts a single command, an array of strings. At present, all schemas for generic-worker accept an array of these commands, so an array of arrays of strings.

For ease of implementation and compatibility for generic-worker docker support we should change the command portion of the docker generic worker payload to match docker-worker's.

Ease of implementation: passing multiple commands to a docker container in sequence requires either wrapping those commands in a script to run or feeding commands via stdin into the container. Rather than wrapping user input in a script ourselves, users should submit input in script form themselves, i.e. ['/bin/bash', '-c', 'ls'].

Comment 1

[Miles Crabill [:miles]]

The existing schema: https://github.com/taskcluster/docker-worker/blob/master/schemas/v1/payload.json#L154-L162

We discussed consistency across the different generic-worker schemas, and decided to stick with an array of arrays, however: the outer array will have a max and min of one item for the docker payload.

Comment 2

[Pete Moore [:pmoore][:pete]]

Generic Worker now fully supports Docker Worker payloads and is actively used for docker-worker tasks in https://firefox-ci-tc.services.mozilla.com/.