Closed Bug 1566946 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17889 - Add per-subtest timeouts to "<img> relevant mutations" test

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17889 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17889
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Add per-subtest timeouts to "<img> relevant mutations" test

The test:

wpt/html/semantics/embedded-content/the-img-element/relevant-mutations.html

relies on the harness timeout if there are any subtests that are waiting
for a 'load' or 'error' event that (erroneously) never arrive. Since the
Blink test runner rely on external timeout handling, this means we never
get any output. This in turn means it's difficult to track changes to
this test.

Add an explicit timeout for the cases mentioned above, using the same
timeout (1000ms) as used for the "expected" timeouts. (Theoretically
this means flakiness, but it's no different than before.) This makes the
subtests FAIL rather than timeout via the harness timeout.

Bug: 834325
Change-Id: I73a909e791d5074d819c750527f80695289f31da
Reviewed-on: https://chromium-review.googlesource.com/1706695
WPT-Export-Revision: 65f6133b9f7728c6c71423c7c83561f9d56a33bc

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Type: -- → task
Ran 1 tests and 81 subtests OK : 1 PASS : 78 FAIL : 3
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9c66b03f4bfb [wpt PR 17889] - Add per-subtest timeouts to "<img> relevant mutations" test, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/6b8227606ff1 [wpt PR 17889] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9c66b03f4bfb
https://hg.mozilla.org/mozilla-central/rev/6b8227606ff1

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.