1566955 - Get rid of main thread requirement in mscom::EnsureMTA

Status: RESOLVED FIXED

(Core :: IPC: MSCOM, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Currently we assert if EnsureMTA is being instantiated off main thread, when the current thread is not already inside an MTA.

The reason for this was because we needed to ensure that sMTAData was only created once, and cleared on shutdown.

We can still do that, but we can also do it in a way that is more thread-friendly.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1566955: Make EnsureMTA fully thread-safe; r=Jamie!

Until now we asserted that EnsureMTA was being called from the main thread
unless the current thread was already in the MTA.

This patch makes MTA thread initialization thread-safe by using a C++11
"magic static," thus allowing EnsureMTA to be safely invoked from any thread.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daf3f25dd398
Make EnsureMTA fully thread-safe; r=Jamie

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/daf3f25dd398