1566956 - Wait for a response from the VideoBridge to ensure textures are available before telling the content process about them.

Status: REOPENED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Initially written as part of bug 1562616, but going to land here.

We have an IPDL triangle between RDD, compositor and the compositor process, and since these are all cross-process connections, races can happen.

This patch makes us wait for a response from the compositor when we add textures, before we tell the content process to start using them.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1566956 - Wait for a response from the VideoBridge to ensure textures are available before telling the content process about them. r?sotaro

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2095b5ca1769
Wait for a response from the VideoBridge to ensure textures are available before telling the content process about them. r=sotaro

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2095b5ca1769

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing Bug 1567002.
https://hg.mozilla.org/mozilla-central/rev/b3f5385fa0b37bca7c46269ff394aca964baec7c

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

That's on Windows Quantumrender, both the normal variant and the socket process one.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mattwoodrow, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Matt Woodrow (:mattwoodrow)]

I haven't had time to finish this, as I'm currently working on Fission.

The issue here is that we're defering the IPDL message about a decoded frame, but other message types aren't deferred, so the ordering changes.

We need to keep a queue of all messages when we start deferring, so that the overall ordering remains the same.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months and this bug has priority 'P2'.
:jimm, could you have a look please?
For more information, please visit auto_nag documentation.