Open Bug 1566956 Opened 1 year ago Updated 2 months ago

Wait for a response from the VideoBridge to ensure textures are available before telling the content process about them.

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

REOPENED

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 obsolete file)

Initially written as part of bug 1562616, but going to land here.

We have an IPDL triangle between RDD, compositor and the compositor process, and since these are all cross-process connections, races can happen.

This patch makes us wait for a response from the compositor when we add textures, before we tell the content process to start using them.

Assignee: nobody → matt.woodrow
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2095b5ca1769
Wait for a response from the VideoBridge to ensure textures are available before telling the content process about them. r=sotaro
Regressions: 1567002
Regressions: 1566995
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Status: RESOLVED → REOPENED
Flags: needinfo?(matt.woodrow)
Resolution: FIXED → ---
Target Milestone: mozilla70 → ---

That's on Windows Quantumrender, both the normal variant and the socket process one.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mattwoodrow, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(matt.woodrow)

I haven't had time to finish this, as I'm currently working on Fission.

The issue here is that we're defering the IPDL message about a decoded frame, but other message types aren't deferred, so the ordering changes.

We need to keep a queue of all messages when we start deferring, so that the overall ordering remains the same.

Flags: needinfo?(matt.woodrow)
Priority: -- → P2
Attachment #9078843 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.