Closed Bug 1567078 Opened 5 years ago Closed 5 years ago

about dialog about:credits link doesn't open

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(thunderbird68 unaffected, thunderbird69 affected)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird68 --- unaffected
thunderbird69 --- affected

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file)

In the about dialog, the link (on nightly) "global community" links to about:credits. Trying to click it you get

Security Error: Content at moz-nullprincipal:{7acf2982-4952-44f9-9610-0e4d3d239cab} may not load or link to about:credits.

Attachment #9078973 - Flags: review?(jorgk)
Comment on attachment 9078973 [details] [diff] [review]
bug1567078_about_credits.patch

Looks OK, I didn't try it. Is this only broken on 70 or 69 also? Seems to be working in TB 68. However, the "Mozilla" link doesn't work in TB 68.
Attachment #9078973 - Flags: review?(jorgk) → review+

Oh, I get it, it comes from the "Apply Meta CSP to more System Privileged about: pages" bug 1492063 and friends, right? So in this case bug 1496010?

Looks like the patch depends on bug 1560094, so if this lands first, you'll need to rebase the other one.

(In reply to Jorg K (GMT+2) from comment #3)

Oh, I get it, it comes from the "Apply Meta CSP to more System Privileged
about: pages" bug 1492063 and friends, right? So in this case bug 1496010?

Looks like it, so 69 is affected.

Please land bug 1560094 first.

Attachment #9078973 - Flags: approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/283e652268d8
about:credits link in about dialog doesn't open. r=jorgk DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0

This fixes bug Bug 1544035 - Many Links in About Window and about:license Broken ?

Flags: needinfo?(mkmelin+mozilla)

For 68, looks like the mozilla link and privacy policy link do not work, and the others work.
Everything should be ok at least after bug 1567103.

Flags: needinfo?(mkmelin+mozilla)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fc1275551c46
Backed out changeset 283e652268d8 to make way for a better solution in bug 1567103. a=backout
Comment on attachment 9078973 [details] [diff] [review]
bug1567078_about_credits.patch

Nothing to uplift here, the action moved to bug 1567103.
Attachment #9078973 - Flags: approval-comm-beta+

Fix is not supplied in bug 1567103.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: