1567083 - Add-on Manager doesn't show header image for signed themes

Status: RESOLVED MOVED

(Thunderbird :: Add-Ons: General, defect)

Description

[Andrei [:sancus]]

Attachment: screenshot of themes tab showing issue

Themes should display their header image in the Add-on Manager, if they have one. The way "Sancus DarkFox" is displayed in the attached screenshot is correct.

However, signed add-ons downloaded from AMO do not display this way, they only show their icon, which isn't very helpful since most themes do not have an icon.

The AMO theme used for testing, "Simple Space Stars" is here: https://addons.mozilla.org/en-US/firefox/addon/simple-space-stars/

I will also attach the xpi for 'Sancus DarkFox'.

Comment 1

[Andrei [:sancus]]

Attachment: XPI for 'Sancus DarkFox', the theme that displays header correctly.

Comment 2

[Mark Barnes [:WoofGrrrr]]

Attachment: Is this the Same Issue??? Thunderbird Add-ons Screenshot 2020-07-10 9-37-31 AM.png

I've attached a screenshot of the Add-ons Themes Tab from TB 68.10.0 (64-bit). The tab is not displaying any images for the themes themselves, but just the "Puzzle Piece" (broken/missing image?) icon.

Is this the same issue?

Comment 3

[John Bieling]

I had a look at this and one difference is here:
https://searchfox.org/mozilla-central/rev/e9eb869e90a8d717678c3f38bf75843e345729ab/toolkit/mozapps/extensions/internal/XPIDatabase.jsm#931

addon._repositoryAddon is always null/undefined for the Firefox theme and we never get the screenshots.

Following the path I saw that caching is not working here:
https://searchfox.org/mozilla-central/rev/e9eb869e90a8d717678c3f38bf75843e345729ab/toolkit/mozapps/extensions/internal/XPIInstall.jsm#1603-1615

getCachedAddonByID() always returns null and the call to cacheAddons() also does not return anything. I followed the execution flow and saw that at one point the ATN server is queried for information from the add-on here:
https://searchfox.org/mozilla-central/rev/e9eb869e90a8d717678c3f38bf75843e345729ab/toolkit/mozapps/extensions/internal/AddonRepository.jsm#484-488

And the following request is not returning the desired information:
https://services.addons.thunderbird.net/api/v3/addons/search/?guid=%7Bb721610c-33d1-498d-b94c-73209c43bbc6%7D&lang=en-US

Because ATN does not know that GUID. So basically this fails for all Firefox-Add-ons/Themes.

Could ATN forward requests to AMO, if we do not know a GUID and fetch the info from there? Otherwise this bug will be very difficult to fix.

Comment 4

[Andrei [:sancus]]

(In reply to John Bieling (:TbSync) from comment #3)

I had a look at this and one difference is here:
Could ATN forward requests to AMO, if we do not know a GUID and fetch the info from there? Otherwise this bug will be very difficult to fix.

In theory it could, yes. When I filed this I didn't realize it was just pulling these from the server every time. This is a website bug then, I think. Not sure if there are any client side changes needed, but I'm just gonna close this for now, if we get the server side functionality and client side changes are needed we can always reopen.

https://github.com/thundernest/addons-server/issues/186

Thanks for looking into this.