1567092 - fluent-reviewer group should not be added to closed diffs

Status: RESOLVED FIXED

(Conduit :: Administration, task)

Description

[Francesco Lodolo [:flod]]

Rule was created in bug 1556780
https://phabricator.services.mozilla.com/H158

I think it should be edited to only be executed for open diffs, but I can't edit the rule directly. I see there's a possibility to filter "Revision status + is any of", maybe "Needs Review", "Needs revision", "Changes planned" would be enough? There's another one "open status" ("Accepted"), but it doesn't seem useful.

For example
https://phabricator.services.mozilla.com/D17731

The group was added as reviewer even if the diff landed 5 months ago, I assume because someone CCed to the bug
https://bugzilla.mozilla.org/show_activity.cgi?id=1519923

Comment 1

[David Lawrence [:dkl]]

Done. I added:

"Revision Status" "is not any of" "Closed"

This should hopefully work the way we want.