1567095 - Add New Address popup field name texts have broken styles

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[pciapa]

Attachment: osx.png

Add New Address popup field name texts have broken styles on OSX and margin is different on Windows and Linux

First name, Middle name, Last name are cutted in top

City, Zip Code, Organization are back to back to field's border and
margins are different as in Windows and Linux.

Comment 1

[pciapa]

Attachment: win10.png

Comment 2

[:Gijs (he/him)]

Is this a recent regression? Are you testing Nightly or another version? What are the steps to reproduce?

Comment 3

[pciapa]

This is recent regression
version 69 0b5
->about:preferences -> Forms and Autofill -> Saved Addresses... -> Add...

Comment 4

[pciapa]

Due to new Mozilla's privacy you also need to set 'browser.search.region', 'US', in some countries to have this feature on

Comment 5

[:Gijs (he/him)]

(In reply to pciapa from comment #3)

This is recent regression
version 69 0b5
->about:preferences -> Forms and Autofill -> Saved Addresses... -> Add...

Can you find a regression window? Is nightly also affected?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I can reproduce this on Nightly.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Bug 1553373 is the regressor.

Hey dao, I think jaws is pretty heads down on Lockwise stuff right now... do you have time to look at this?

Comment 8

[pciapa]

As for step to reproduce:
Preconditions

Beta:

• extensions.formautofill.available set to "on"./extensions.formautofill.creditCards.available;true/extensions.formautofill.creditCards.enabled;true
• Go to Preferences(Options)/ Privacy and Security / Form Autofill / Enable Saved Credit Cards
• Make sure you have at least one saved Credit Card information.

Note: Form autofill is enabled by default in Nightly.

as for regression window - asked from my manual testers colleagues who have this zone of responsibility. But I see that you already found it

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

:pciapa, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 10

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
User-visible regression in 69 that we can probably still avoid shipping with a low-risk CSS patch.

Comment 11

[:Gijs (he/him)]

Attachment: Bug 1567095 - fix styling of address inputs in preferences, r?dao

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa220bc8882
fix styling of address inputs in preferences, r=dao

Comment 13

[:Gijs (he/him)]

Comment on attachment 9080279 [details]
Bug 1567095 - fix styling of address inputs in preferences, r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Broken styling for form autofill
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See other comments in this bug.
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 1-rule CSS patch specific to the broken stuff here to fix the regression.

(Requesting approval early as I'm on PTO for 2 weeks from tomorrow.)

• String changes made/needed: nope

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5fa220bc8882

Comment 15

[Gabi Cheta [:Gabi] Desktop QA]

Verified on Windows 10 x64 and MacOS 10.12 with Nightly 70.0a1 and while the address text fields look ok, the credit card pop up field name text does not look fixed. Please see the new attachment for macOS.

Let me know if we should file a separate issue for this.

Comment 16

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: macOS.png

Comment 17

[:Gijs (he/him)]

(In reply to Gabi Cheta [:Gabi] Release Desktop QA from comment #15)

Verified on Windows 10 x64 and MacOS 10.12 with Nightly 70.0a1 and while the address text fields look ok, the credit card pop up field name text does not look fixed. Please see the new attachment for macOS.

Let me know if we should file a separate issue for this.

Yes, please file a separate issue and request tracking for 69 + 70 as appropriate.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9080279 [details]
Bug 1567095 - fix styling of address inputs in preferences, r?dao

Form autofill styling improvement. Approved for 69.0b9.

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba70f4987ba6

Comment 20

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with 69.0b9 and Nightly 70.0a1 on Windows 10x64, Ubuntu 16.04 and MacOS 10.12.
Opened 1569963 for the Edit Credit Card fields issue.