1567117 - Bustages on src/debugger/NoExecute.cpp when Gecko 70 merges to Beta on 2019-08-26

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Cosmin Sabou [:CosminS]]

[Tracking Requested - why for this release]:
Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=257121645&resultStatus=retry%2Cbusted%2Crunnable&revision=64c85e07b5f3ce2262295debbd63726f0b4db41a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257121645&repo=try&lineNumber=766

[task 2019-07-18T10:46:01.302Z] /builds/worker/workspace/clang/bin/clang++ -o Object.o -c -I/builds/worker/workspace/build/src/obj-spider/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DWASM_HUGE_MEMORY -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/debugger -I/builds/worker/workspace/build/src/obj-spider/js/src/debugger -I/builds/worker/workspace/build/src/obj-spider/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-spider/dist/include -I/builds/worker/workspace/build/src/obj-spider/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-spider/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fsanitize=address -U_FORTIFY_SOURCE -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gline-tables-only -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/Object.o.pp /builds/worker/workspace/build/src/js/src/debugger/Object.cpp
[task 2019-07-18T10:46:01.302Z] js/src/debugger/Script.o
[task 2019-07-18T10:46:01.751Z] /builds/worker/workspace/build/src/js/src/debugger/NoExecute.cpp:64:7: error: use of undeclared identifier 'SprintfLiteral'
[task 2019-07-18T10:46:01.752Z] SprintfLiteral(linenoStr, "%u", script->lineno());
[task 2019-07-18T10:46:01.752Z] ^
[task 2019-07-18T10:46:01.965Z] 1 error generated.
[task 2019-07-18T10:46:01.971Z] /builds/worker/workspace/build/src/config/rules.mk:801: recipe for target 'NoExecute.o' failed
[task 2019-07-18T10:46:01.971Z] make[3]: *** [NoExecute.o] Error 1
[task 2019-07-18T10:46:01.971Z] make[3]: *** Waiting for unfinished jobs....

This looks to be a regression from Bug 1564164 https://hg.mozilla.org/mozilla-central/rev/89e578d071379c4d849030dd27f855c64c58269a
Jim, could you please take a look? Thank you.

Comment 1

[Cosmin Sabou [:CosminS]]

This required a backout of bug 1564170, bug 1564164, bug 1565275, bug 1566899 in order to not have conflicts while backing out
https://hg.mozilla.org/try/rev/fd8c926c7463467db93532a320e0bb6d34a7efb2
Th link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ed0bda8c2becca0e0a0a871434f5f2e7aec1bead

Comment 2

[Andreea Pavel [:apavel]]

List of bugs needed to be backed out to not have conflicts while backing out bug 1564164 is now the following: Bug 1564170, Bug 1564164, Bug 1565275, Bug 1565704, Bug 1566899, Bug 1566803

Comment 3

[Jim Blandy :jimb]

This should be a very easy fix. I think it's just a missing #include.

Those bugs are going to be a bear to back out, because they're breaking up a giant C++ file into several different files - any change anywhere in the file will conflict. Let's see if we can't make this work first.

Comment 4

[Jim Blandy :jimb]

Attachment: Bug 1567117: Add missing #include in js/src/debugger/Script.cpp. r?jorendorff

Comment 5

[Alexandru Michis [:malexandru]]

The patch works in the latest central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=003c357a66ccc63e1b70d5d6977d7c096280aeed&group_state=expanded&selectedJob=257856677

I'll go ahead and land the patch since it's been reviewed already.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc617e7365e6
Add missing #include in js/src/debugger/Script.cpp. r=jorendorff

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fc617e7365e6