1567134 - ESLint builders are downloading modules from npm

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P1)

Description

[Mark Banner (:standard8)]

I just noticed that bug 1564138 changed the top-level package.json, and that's caused the ESLint builders to download directly from npm.

We should fix the fundamental issue, for which I've filed bug 1567132. I probably won't have time for that for a couple of weeks.

In the meantime, I'll post the quick patch to update the builders properly and get us in a good state again.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1567134 - Update the node modules packages for the builders. r?ahal

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10264d61e544
Update the node modules packages for the builders. r=ahal

Comment 4

[Mike Hommey [:glandium]]

Does npm have a flag like cargo's --frozen, that prevents it from downloading stuff?

Comment 5

[Mark Banner (:standard8)]

(In reply to Mike Hommey [:glandium] from comment #4)

Does npm have a flag like cargo's --frozen, that prevents it from downloading stuff?

Not that I can see. Once we get to vendoring, we shouldn't have this problem. In the meantime, bug 1567132 should be an easy way to prevent this happening (I'm just out from today for a week, so haven't had time).

Comment 6

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) (afk 19th - 28th July) from comment #5)

(In reply to Mike Hommey [:glandium] from comment #4)

Does npm have a flag like cargo's --frozen, that prevents it from downloading stuff?

Not that I can see. Once we get to vendoring, we shouldn't have this problem. In the meantime, bug 1567132 should be an easy way to prevent this happening (I'm just out from today for a week, so haven't had time).

Actually, bug 1567132 is probably the main issue here. We shouldn't be running npm install/ci on the builders as we already have node_modules unpackaged.

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/10264d61e544