1567164 - Export Changes - Copy Rule does not copy CSS Rule text

Status: VERIFIED FIXED

(DevTools :: Inspector: Changes, defect, P1)

Description

[Razvan Caliman [:rcaliman]]

The patch for Bug 724505 changed the output format of the prettifyCSS() method from a string to an object. This has a knock-on effect on the output of Copy Rule from the Changes panel which expects a string, but now receives an object.

Steps to reproduce:

• Open DevTools Inspector
• Make any change to a CSS rule in the Rules panel
• Switch to the Changes panel
• Move the mouse over tracked change and press the Copy Rule button that appears on hover.
• Paste the clipboard content to a file

Expected result
The full contents of the changed CSS rule are pasted.

Actual
The string [Object object] is pasted.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rcaliman, could you try to find a regression range in using for example mozregression?

Comment 2

[Eddie Carswell]

I encountered this same problem last week (I'm using latest Nightly). I don't recall it being an issue a month ago though.

Comment 3

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1567164 - Ensure StyleRuleActor.getRuleText() returns text content of minified CSS. r=gl

The patch for Bug 724505 changed the return of prettifyCSS() from a string to an object and the reference in the StyleRuleActor.getRuleText() was not updated. This patch fixes this and introduces a test.

Comment 4

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2051a4424e4322549149e9294d09e96e532a621d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdd5b5134737
Ensure StyleRuleActor.getRuleText() returns text content of minified CSS. r=gl

Comment 6

[Razvan Caliman [:rcaliman]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #1)

:rcaliman, could you try to find a regression range in using for example mozregression?

Is a regression range still required if I already found the issue (bug 724505) which caused the regression?

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/bdd5b5134737

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sounds like you found the regression range! Did you want to nominate this for Beta uplift too?

Comment 9

[Razvan Caliman [:rcaliman]]

Comment on attachment 9079361 [details]
Bug 1567164 - Ensure StyleRuleActor.getRuleText() returns text content of minified CSS. r=gl

Beta/Release Uplift Approval Request

• User impact if declined: Users are unable to use the "Copy Rule" functionality of the Changes panel to export their changes. This is a regression of existing functionality which users expect as a core feature of the Changes panel.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch fixes previously working functionality and has a low risk. It also introduces an automated test.
• String changes made/needed:

Comment 10

[Razvan Caliman [:rcaliman]]

Thank you, Ryan!
Yes, we'd like to uplift this to Beta so it no longer impacts Beta/Developer Edition users and to ensure that Release has no blackout of the functionality in the Changes panel.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9079361 [details]
Bug 1567164 - Ensure StyleRuleActor.getRuleText() returns text content of minified CSS. r=gl

Fixes a new regression in 69 which was causing the "Copy Rule" functionality to misbehave. Thanks for including a test. Approved for 69.0b8.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e778d09c6b2

Comment 14

[Cristian Fogel [:cfogel]]

Verified with 69.0b8, 70.0a1 (2019-07-25).