Closed Bug 1567167 Opened 1 year ago Closed 1 year ago

Remove webconsoleClient calls within JsTerm

Categories

(DevTools :: Console, task, P1)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission)

Attachments

(4 files)

No description provided.
Whiteboard: dt-fission

The function is only called from the context-menu,
where we already have all the references we need.
So we can move the function code directly in the
menu item callback.

Depends on D38612

This shouldn't be JSTerm's responsability to call
this function. Furthermore, the function clear
some references in the WebConsoleFront, which are
going to be destroyed anyway.

Depends on D38613

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/621f1f846464
Remove unused gSequenceId function in JSTerm . r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/d0c3b8c500e1
Remove copyObject function from JSTerm. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/5f481c196743
Remove clearNetworkRequests from JsTerm destroy function. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/bf0b7dffc7b4
Remove webConsoleClient getter from JSTerm. r=jdescottes.
You need to log in before you can comment on or make changes to this bug.