1567167 - Remove webconsoleClient calls within JsTerm

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1567167 - Remove unused gSequenceId function in JSTerm . r=jdescottes.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1567167 - Remove copyObject function from JSTerm. r=jdescottes.

The function is only called from the context-menu,
where we already have all the references we need.
So we can move the function code directly in the
menu item callback.

Depends on D38612

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1567167 - Remove clearNetworkRequests from JsTerm destroy function. r=jdescottes.

This shouldn't be JSTerm's responsability to call
this function. Furthermore, the function clear
some references in the WebConsoleFront, which are
going to be destroyed anyway.

Depends on D38613

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1567167 - Remove webConsoleClient getter from JSTerm. r=jdescottes.

Depends on D38614

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/621f1f846464
Remove unused gSequenceId function in JSTerm . r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/d0c3b8c500e1
Remove copyObject function from JSTerm. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/5f481c196743
Remove clearNetworkRequests from JsTerm destroy function. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/bf0b7dffc7b4
Remove webConsoleClient getter from JSTerm. r=jdescottes.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/621f1f846464
https://hg.mozilla.org/mozilla-central/rev/d0c3b8c500e1
https://hg.mozilla.org/mozilla-central/rev/5f481c196743
https://hg.mozilla.org/mozilla-central/rev/bf0b7dffc7b4