1567180 - Update etp header section on protection report

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Erica Wright [:ewright]]

• Add new icon
• Update string depending on category

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1567180 - Update etp header section on protection report

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/725ef2e2a53e
Update etp header section on protection report r=fluent-reviewers,mtigley,flod

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset 725ef2e2a53e (bug 1567180) for failing at /browser_protections_report_ui.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/86aaa1298ed03445bab82eeb6d7d11cafdeace59

**Push with failures:**https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=725ef2e2a53e6ba90304c4aefee63bc1a4440ff5&selectedJob=257401220

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257401220&repo=autoland&lineNumber=4822

Log snippet:

15:13:08 INFO - TEST-PASS | browser/components/protections/test/browser/browser_protections_report_ui.js | The custom string is showing - "protection-header-details-custom" == "protection-header-details-custom" -
15:13:08 INFO - Leaving test bound test_etp_header_string
15:13:08 INFO - Buffered messages finished
15:13:08 INFO - TEST-UNEXPECTED-FAIL | browser/components/protections/test/browser/browser_protections_report_ui.js | A promise chain failed to handle a rejection: [Exception... "Component not initialized" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/remotepagemanager/MessagePort.jsm :: sendAsyncMessage :: line 336" data: no] - stack: sendAsyncMessage@resource://gre/modules/remotepagemanager/MessagePort.jsm:336:25
15:13:08 INFO - sendMessage@resource:///modules/aboutpages/AboutProtectionsHandler.jsm:130:14
15:13:08 INFO - receiveMessage@resource:///modules/aboutpages/AboutProtectionsHandler.jsm:177:14
15:13:08 INFO - AsynccallListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:141:9
15:13:08 INFO - portMessageReceived@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:94:19
15:13:08 INFO - callListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:141:9
15:13:08 INFO - handleMessage@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:266:19
15:13:08 INFO - message@resource://gre/modules/remotepagemanager/MessagePort.jsm:300:10
15:13:08 INFO - MessageListener.receiveMessageaddMessageListeners@resource://gre/modules/remotepagemanager/MessagePort.jsm:192:25
15:13:08 INFO - MessagePort@resource://gre/modules/remotepagemanager/MessagePort.jsm:188:10
15:13:08 INFO - ChromeMessagePort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:197:5
15:13:08 INFO - initPort@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:340:16
15:13:08 INFO - MessageListener.receiveMessage*init@resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:295:17
15:13:08 INFO - @resource://gre/modules/remotepagemanager/RemotePageManagerParent.jsm:349:27
15:13:08 INFO - startup@resource://gre/modules/AddonManager.jsm:890:41
15:13:08 INFO - startup@resource://gre/modules/AddonManager.jsm:3465:26
15:13:08 INFO - observe@resource://gre/modules/addonManager.js:86:29
15:13:08 INFO - Rejection date: Fri Jul 19 2019 15:13:08 GMT+0000 (Greenwich Mean Time) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 263
15:13:08 INFO - Stack trace:
15:13:08 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:263
15:13:08 INFO - chrome://mochikit/content/browser-test.js:nextTest:908
15:13:08 INFO - chrome://mochikit/content/browser-test.js:testScope/test_finish/<:1728
15:13:08 INFO - chrome://mochikit/content/browser-test.js:run:1643
15:13:08 INFO - GECKO(1083) | MEMORY STAT | vsize 5292MB | residentFast 316MB | heapAllocated 141MB
15:13:08 INFO - TEST-OK | browser/components/protections/test/browser/browser_protections_report_ui.js | took 912ms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cee78da90e54
Update etp header section on protection report r=fluent-reviewers,mtigley,flod

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/cee78da90e54