Closed Bug 1567192 Opened 2 years ago Closed 2 years ago

[Protections Panel] Show the blue dot indicator when tracking protection is opt-out for a given site.

Categories

(Firefox :: Site Identity, task, P1)

task

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified

People

(Reporter: timhuang, Assigned: timhuang)

References

(Blocks 1 open bug)

Details

(Whiteboard: [skyline])

Attachments

(5 files)

No description provided.
Whiteboard: [privacy-panel][triage][skyline] → [skyline]

This patch adds a blue dot indicator on top of the tracking protection
icon if the tracking protection is disabled for the given site.

This patch makes the blue dot in the TP switch section to be related to
the 'enabled' attribute of the TP switch section.

Depends on D40173

This patch makes the blue dot to be shown when the tracking protection
is disabled. And this updates the style of the blue dot on the TP switch
to match the spec.

Depends on D40174

This patch adds two more checks for the icon state in the current TP
switch flow test.

Depends on D40176

Attachment #9082197 - Attachment description: Bug 1567192 - Part 1: Add the blue dot on top of the tracking protection icon and show it when tracking protection is disabled for the given site. → Bug 1567192 - Part 1: Add the blue dot on top of the tracking protection icon and show it when tracking protection is disabled for the given site. r?nhnt11
Attachment #9082198 - Attachment description: Bug 1567192 - Part 2: Make the blue dot indicator on the TP switch to be related to the TP switch enable state. nhnt11 → Bug 1567192 - Part 2: Make the blue dot indicator on the TP switch to be related to the TP switch enable state. r?nhnt11
Attachment #9082197 - Attachment description: Bug 1567192 - Part 1: Add the blue dot on top of the tracking protection icon and show it when tracking protection is disabled for the given site. r?nhnt11 → Bug 1567192 - Part 1: Add the blue dot on top of the tracking protection icon and show it when tracking protection is disabled for the given site. r?nhnt11!
Attachment #9082198 - Attachment description: Bug 1567192 - Part 2: Make the blue dot indicator on the TP switch to be related to the TP switch enable state. r?nhnt11 → Bug 1567192 - Part 2: Make the blue dot indicator on the TP switch to be related to the TP switch enable state. r?nhnt11!
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c99401bcd16f
Part 1: Add the blue dot on top of the tracking protection icon and show it when tracking protection is disabled for the given site. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/79bd0b84d613
Part 2: Make the blue dot indicator on the TP switch to be related to the TP switch enable state. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/67f69ab73892
Part 3: Show the blue dot on the TP switch in the protection panel if needed and update its style. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/aa4aba94d3dc
Part 4: Change the trakcing protection icon state when toggling the TP switch in the protection panel and update the timeout of the toast to match the spec. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/0609cad96ae4
Part 5: Update test browser_protections_UI.js in order to test the tracking protection state during the TP switch flow. r=nhnt11

Confirming this issue as verified fixed on 70.0a1 (2019-08-15) with Windows 10x64 , Ubuntu 18.04 and macOS 10.14.6. The blue dot is displayed when Tracking Protection is disabled.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.