Open Bug 1567205 Opened 6 years ago Updated 3 years ago

nsBaseHashtable (and others?) -- be clearer on what a "simple" type is

Categories

(Core :: XPCOM, task)

task

Tracking

()

Tracking Status
firefox70 --- affected

People

(Reporter: Gankra, Unassigned)

Details

In this comment: https://searchfox.org/mozilla-central/source/xpcom/ds/nsBaseHashtable.h#40-41

It is said that "this class manages simple data types that do not need construction or destruction."

This is startling to read, because it suggests we cannot use nsTArray or any other non-trivial type. However I believe what this comment is really saying is that it cannot hold types with non-trivial moves (things with intrusive pointers), similar to the constraint on nsTArray's own contents.

Component: MFBT → XPCOM
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.