1567232 - Add extra proguard rules for R8 compatibility

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Imanol Fernandez]

R8 is replacing Proguard in Android tools. I'm working on enabling R8 minification for Firefox Reality and found some problems with the GV library.

Crash related to not registering a native method correctly

 Failed to register native method org.mozilla.gecko.process.GeckoProcessManager.nativeGetEditableParent(Lorg/mozilla/gecko/IGeckoEditableChild;JJ)V in base.apk
----- class 'Lorg/mozilla/gecko/process/GeckoProcessManager;' cl=0x18f82068 -----
  objectSize=256 (120 from super)
  access=0x0000.0011
  super='java.lang.Class<h.c.a.e.g>' (cl=0x18f82068)
  vtable (4 entries, 3 in super):
     0: int org.mozilla.gecko.process.GeckoProcessManager.a(java.lang.String, java.lang.String[], int, int, int, int, int, boolean, android.os.RemoteException)
     1: org.mozilla.gecko.process.GeckoProcessManager$a org.mozilla.gecko.process.GeckoProcessManager.a(java.lang.String)
     2: void org.mozilla.gecko.process.GeckoProcessManager.a(h.c.a.E, long, long)
     3: void org.mozilla.gecko.process.GeckoProcessManager.a(java.lang.String[])
  direct methods (5 entries):
     0: void org.mozilla.gecko.process.GeckoProcessManager.<clinit>()
     1: void org.mozilla.gecko.process.GeckoProcessManager.<init>()
     2: void org.mozilla.gecko.process.GeckoProcessManager.nativeGetEditableParent(h.c.a.E, long, long)
     3: void org.mozilla.gecko.process.GeckoProcessManager.setEditableChildParent(h.c.a.E, h.c.a.H)
     4: int org.mozilla.gecko.process.GeckoProcessManager.start(java.lang.String, java.lang.String[], int, int, int, int, int)
  static fields (1 entries):
     0: org.mozilla.gecko.process.GeckoProcessManager org.mozilla.gecko.process.GeckoProcessManager.a
  instance fields (1 entries):
     0: b.d.i org.mozilla.gecko.process.GeckoProcessManager.b
Failed to register native method 

And also a JNI error with this message:

FATAL JNI ERROR! FindClass("org/mozilla/gecko/mozglue/JNIObject") failed. Does the class require a newer API version? Or did ProGuard optimize away something it shouldn't have?

Comment 1

[Imanol Fernandez]

Attachment: Bug 1567232 - Add extra proguard rules for R8 compatibility.

Summary Add extra proguard rules for R8 compatibility.:

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c535f1c30e
Add extra proguard rules for R8 compatibility. r=agi

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/79c535f1c30e

Comment 4

[Chris Peterson [:cpeterson]]

68=fix-optional because I don't think we need to uplift to GV 69 Beta if this bug doesn't affect Fenix. FxR still uses GV Nightly.

Comment 5

[Imanol Fernandez]

We found some a new crash related to R8 when playing media: https://crash-stats.mozilla.com/report/index/308c9afa-c805-42b9-a354-cef020190722

Comment 6

[Imanol Fernandez]

Attachment: Bug 1567232 - Add more proguard rules for R8 compatibility.

Add more proguard rules for R8 compatibility

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d1a7f0243d3
Add more proguard rules for R8 compatibility. r=agi,rbarker

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3d1a7f0243d3