Proxy Connection setting Ok button not visible
Categories
(Thunderbird :: Preferences, defect)
Tracking
(thunderbird_esr68 fixed, thunderbird69 fixed, thunderbird70 fixed)
People
(Reporter: jaise, Assigned: Paenglab)
References
Details
Attachments
(3 files)
78.35 KB,
image/jpeg
|
Details | |
95.85 KB,
image/jpeg
|
Details | |
2.10 KB,
patch
|
jorgk-bmo
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0
Steps to reproduce:
In Proxy Connection setting Ok/Cancel button not visible in wide screen monitor[pic attached]. also attached Firefox connection setting picture.
Assignee | ||
Comment 2•2 years ago
|
||
We missed to port this change: https://hg.mozilla.org/mozilla-central/diff/ff4c77d7c5ea2cb88d321f44bd9d80ac5c3ab08a/browser/components/preferences/in-content/subdialogs.js from bug 1493844.
Comment 3•2 years ago
|
||
Hmm, this still doesn't look good. The subdialogue is very high and I didn't see the buttons at first. There's a lot of empty space above the buttons, under the "DNS over HTTP" popup. BTW, that's empty here, in the reporters pictures I can see "Cloudflare (Default)".
Assignee | ||
Comment 4•2 years ago
|
||
The space above is for the textfield when you select Custom in the menulist. On Beta it works, it seems the prefs reordering broke the menulist.
Make the TB window only 500px tall and see the difference with and without the patch.
Comment 5•2 years ago
|
||
Comment on attachment 9079413 [details] [diff] [review] 1567371-subdialog-scrollbar.patch OK, thanks. Please file a bug for the broken "DNS over HTTP".
Updated•2 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/183d48f45b75
Port bug 1493844, subdialogs.js part, to fix connection settings subdialog. r=jorgk
Updated•2 years ago
|
Assignee | ||
Comment 7•2 years ago
|
||
Why the change in connection.js?
Comment 8•2 years ago
|
||
Damn, I was trying to look at bug 1567622 and that change slipped it, grrr. I did a local hg qref to update the commit message :-(
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/e94d7ea656dc Follow-up: Revert hunk that was added accidentally. r=me DONTBUILD
Comment 10•2 years ago
|
||
UPLIFT REMINDER: Merge both changesets or use original patch.
Comment 11•2 years ago
|
||
TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/0cb3f49224430ab6e0d656f22ff07ec97d3ba8ce (merged patch)
Comment 14•2 years ago
|
||
TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/11733b662e351281a188f565afbafdb73e4b5783
Description
•