1567371 - Proxy Connection setting Ok button not visible

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jaise]

Attachment: Connection setting in firefox.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

In Proxy Connection setting Ok/Cancel button not visible in wide screen monitor[pic attached]. also attached Firefox connection setting picture.

Comment 1

[Jaise]

Attachment: Connection setting Thunderbird.jpg

Comment 2

[Richard Marti (:Paenglab)]

Attachment: 1567371-subdialog-scrollbar.patch

We missed to port this change: https://hg.mozilla.org/mozilla-central/diff/ff4c77d7c5ea2cb88d321f44bd9d80ac5c3ab08a/browser/components/preferences/in-content/subdialogs.js from bug 1493844.

Comment 3

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

Hmm, this still doesn't look good. The subdialogue is very high and I didn't see the buttons at first. There's a lot of empty space above the buttons, under the "DNS over HTTP" popup. BTW, that's empty here, in the reporters pictures I can see "Cloudflare (Default)".

Comment 4

[Richard Marti (:Paenglab)]

The space above is for the textfield when you select Custom in the menulist. On Beta it works, it seems the prefs reordering broke the menulist.

Make the TB window only 500px tall and see the difference with and without the patch.

Comment 5

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

Comment on attachment 9079413 [details] [diff] [review]
1567371-subdialog-scrollbar.patch

OK, thanks. Please file a bug for the broken "DNS over HTTP".

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/183d48f45b75
Port bug 1493844, subdialogs.js part, to fix connection settings subdialog. r=jorgk

Comment 7

[Richard Marti (:Paenglab)]

Why the change in connection.js?

Comment 8

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

Damn, I was trying to look at bug 1567622 and that change slipped it, grrr. I did a local hg qref to update the commit message :-(

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e94d7ea656dc
Follow-up: Revert hunk that was added accidentally. r=me DONTBUILD

Comment 10

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

UPLIFT REMINDER: Merge both changesets or use original patch.

Comment 11

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/0cb3f49224430ab6e0d656f22ff07ec97d3ba8ce (merged patch)

Comment 12

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

Working in TB 69 beta.

Comment 14

[Jorg K (GMT+2) (reduced availability 14-19 of Sept.)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/11733b662e351281a188f565afbafdb73e4b5783