Update react-redux libraries in DevTools
Categories
(DevTools :: General, task, P3)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(1 obsolete file)
We have not update our vendored redux.js library in a while.
We are now several versions behind react-redux.js (which is also vendored in devtools).
redux.js currently sits at while react-redux.js is v5.0.7
We should probably mention in both REACT_REDUX_UPGRADING.md and REDUX_UPGRADING.md that the versions of both libs should remain in sync.
It's not breaking anything per se, but it's just unsettling to have those different versions around at the same time.
Reporter | ||
Comment 1•5 years ago
|
||
Even though we did miss a few updates, both libraries don't share the same release cycle at all.
Currently redux.js latest version is 4.0.4 https://github.com/reduxjs/redux. I'm not sure there's a strong incentive for us to update here, given that we can't force the two libs to be in sync or whatever. What do you think?
Assignee | ||
Comment 2•5 years ago
|
||
I had a patch at some point to update both redux
and react-redux
when Bug 1560006 lands.
There was a blog post (that I can't find now), that was stating that the latest react-redux
was the fastest version ever, making use of React hooks (hence the dependency on the new React version). I think it's also depending on latest redux
.
So the incentive is this performance claim the react-redux team made, and now that Bug 1560006 is close to be resolved, I'll go on with my old patch and trigger some TRY run to see if that's true :)
if it doesn't, it's not a bad thing to update the libraries anyway (unless it's causing super bad performance regressions).
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Sounds good!
Just a final note that react-redux v5.0.7 was depending on redux ^3.0.0, so our versions where correct here.
react-redux started depending on redux ^4.0.0 after v5.1.0: https://github.com/reduxjs/react-redux/blob/v5.1.0/package.json#L81
Assignee | ||
Comment 4•4 years ago
|
||
Redux is updated to v4.0.5 and react-redux to v7.1.3.
The react-redux createProvider function was removed,
so we needed to change the Debugger setup to be able
to consume both the debugger redux store as well as
the toolbox one.
Assignee | ||
Comment 5•4 years ago
|
||
The DAMP run seems to indicate there's no perf improvements, and even highlights 2 non-negligible regressions in inspector and webconsole: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&newProject=try&newRevision=793001084ea8f3a25f276504b4bd7ba7c8cb6c27&originalSignature=1759151&newSignature=1759151&framework=12&originalRevision=932c1621e8e42cc0ad5616887564d57b80c15887
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•2 years ago
|
Description
•