1567421 - Unable to playback short sounds on Samsung devices

Status: RESOLVED DUPLICATE of bug 1565838

(Firefox for Android Graveyard :: Audio/Video, defect, P2)

Description

[sss1024]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36

Steps to reproduce:

Use code like this
audioContext.decodeAudioData(arraybuffer, function (audioBuffer) {

see full description
https://github.com/surikov/webaudiofont/issues/35

Actual results:

Browser console shows
The buffer passed to decodeAudioData contains invalid content which cannot be decoded successfully.
EncodingError: The given encoding is not supported.

Expected results:

calback function invoke without error messages

Comment 1

[Paul Adenot (:padenot)]

STR:

https://surikov.github.io/webaudiofont/examples/simple.html#, click "Play a note".

Expected:

There is a sounds

Actual:

There is no sound.

I can't repro here, all version so Firefox work well on my Sony XZ1 compact.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Works for me as well. Asked about the device/OS that the reporter uses in the GitHub issue.

Comment 3

[Michael Froman [:mjf]]

Updated info from the GitHub issue:
I am using a Samsung Galaxy Express Prime running Android 9.0. It is funny because my wife's LG has FF 68.0 and Andriod 8 something and it works. And a friend who is running Andriod 8.1 has FF 68.0 and it works on his phone. Chrome works on my phone. I have uninstalled and reinstalled FF. I have installed the Beta and the Nightly and it fails on all of those on my phone. It might be a way that FF 68.0 accesses some underlying library which might have changed in Android 9.0. But that is weird because Chrome works. So, I'm not sure what the source of this problem is exactly.

Comment 4

[Michael Froman [:mjf]]

Marked this P2, feel free to adjust.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

2019-07-19T15:12:24: INFO : Narrowed inbound regression window from [216f1bef, 7a04d9e5] (4 builds) to [634737ac, 7a04d9e5] (2 builds) (~1 steps left)
2019-07-19T15:12:24: DEBUG : Starting merge handling...
2019-07-19T15:12:24: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=7a04d9e5975407828f087eb38ac6d4b51deada94&full=1
2019-07-19T15:12:25: DEBUG : Found commit message:
Bug 1540748 - part2 : add warning for negative adjusted time. r=jolin

As the purpose of adjusting time is to make the start of the playback to align to zero, so the result should not be negative.

However, we can't always ensure the demuxed start time is correct, the decoded first frame sample time might be different with the time demuxer provides.

Even if we try to update the start time when we get the first decoded sample, there is still a problem because a decoder might return samples with different order, which means the first frame the decoder returns is probably not a real first frame.

Therefore, using warning to help us knows how many this situaion would be.

Differential Revision: https://phabricator.services.mozilla.com/D28432

Comment 6

[Chris Peterson [:cpeterson]]

@ sss1024 and mjf: are you able to reproduce the error in Fenix (Firefox Preview)?

https://play.google.com/store/apps/details?id=org.mozilla.fenix

Comment 7

[Alastor Wu [:alwu]]

Hi, Join,
It seems that we would hit the error where the sample time decoder returns is smaller than the time we feed into on some Samung devices, any ideas?

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

Chris, yes this reproduces on Fenix.

Comment 9

[John Lin [:jhlin][:jolin]]

Kevin, thanks a lot for the regression range!

Could you please help test with lastest Fennec Beta [1]? Some patches that fix a similar regression (bug 1552607, bug 1560611) have been uplifted, but I don't have a Samsung phone to verify it myself.

[1] http://ftp.mozilla.org/pub/mobile/releases/68.1b3/android-api-16/en-US/fennec-68.1b3.en-US.android-arm.apk

Comment 11

[scott]

I have installed the 68.1b3 apk and the bug remains. Console outputs the same error.
The buffer passed to decodeAudioData contains invalid content which cannot be decoded successfully.
EncodingError: The given encoding is not supported.
This is on a Samsung phone. I'm the original poster of 1570360.

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Same.

Comment 13

[John Lin [:jhlin][:jolin]]

Turns out this is the same as bug 1565838. Uploaded the patch there and mark this as dup.

Comment 14

[Diana Rus]

Hi, I managed to reproduce the issue with Samsung Galaxy S9 (Android 8) build Firefox Release 68.0 build 2.
I did a check on the build Firefox Release 68.6.0 and Firefox Beta 68.7b1 with Samsung Galaxy S9 (Android 8) and the issue does not reproduce.

Note: Did a check on Firefox Preview Nightly 200323 (Build #20830607) GV: 76.0a1-20200319094444 and the issue does not reproduce.