1567422 - "Tracking Protections" icon doesn't have hovering tooltip in some cases

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

STR:

1. Open this website page - https://hg.mozilla.org/
2. Hover pointer/mouse cursor over "Tracking Protections" menu
   and see that it doesn't have hovering tooltip

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Virtual, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[Tim Huang[:timhuang]]

We should also fix the label for accessibility here. see Bug 1552716 comment 1.

Comment 4

[Tim Huang[:timhuang]]

Hi Jamie,

I have a question about the accessibility of the tracking protection icon. IIUC, we don't need the 'aria-label' if we have a tooltip text on the tracking protection icon unless we want to show something else other than the tooltip text. Is that correct?

Comment 5

[Marco Zehe (:MarcoZ)]

Quickly filling in for Jamie here: That is correct. aria-label is only needed if this should be different from the tooltiptext. You can check what gets exposed as the accessible name by using the Accessibility Inspector in the Browser Toolbox and inspecting the accessibility tree of the button. The Name property is what you're looking for.

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1567422 - Part 1: Remove the old tooltip strings. r?johannh!,flod!

The patch removes the old string of the tooltip on the trakcing
protection icon and replace them with the new strings.

Comment 7

[Tim Huang[:timhuang]]

Attachment: Bug 1567422 - Part 2: Update the tooltip of the tracking protection icon. r?johannh!

This patch modify the way how tooltip works on the tracking protection
icon. We use <tooltip> instead of 'tooltiptext' attribute in order to
limit the width of the tooltip in 500px.

Depends on D40415

Comment 8

[Tim Huang[:timhuang]]

Attachment: Bug 1567422 - Part 3: Add support of the accessibility for the tracking protection icon tooltip. r?johannh!

Set the 'aria-label' to the tracking protection icon container in order
to support the accessibility. We need this here since the accessiblity
won't automatically get the <tooltip> element here,

Depends on D40416

Comment 9

[Tim Huang[:timhuang]]

Attachment: Bug 1567422 - Part 4: Update tests. r?johannh!

Depends on D40417

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1284a6b493d9
Part 1: Remove the old tooltip strings. r=johannh,flod
https://hg.mozilla.org/integration/autoland/rev/788a0b069454
Part 2: Update the tooltip of the tracking protection icon. r=johannh
https://hg.mozilla.org/integration/autoland/rev/249534a19058
Part 3: Add support of the accessibility for the tracking protection icon tooltip. r=johannh
https://hg.mozilla.org/integration/autoland/rev/c6594cf68af6
Part 4: Update tests. r=johannh

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1284a6b493d9
https://hg.mozilla.org/mozilla-central/rev/788a0b069454
https://hg.mozilla.org/mozilla-central/rev/249534a19058
https://hg.mozilla.org/mozilla-central/rev/c6594cf68af6

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-08-07), so I'm marking this bug as VERIFIED.
Thank you very much! \o/