Closed
Bug 156747
Opened 22 years ago
Closed 20 years ago
stop including res/samples and res/throbber in packages
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmd, Assigned: benjamin)
References
(Depends on 1 open bug)
Details
(Keywords: memory-footprint)
Attachments
(2 files)
2.31 KB,
patch
|
dveditz
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
4.34 KB,
patch
|
dveditz
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
The files installed in res/samples take approx. 200k compressed, and over 500k when installed. These "samples" have been in the install forever...since I started doing QA in M13-ish time. With the figures I have, I estimate at least 4.5 million downloads of mozilla release/nightly versions since that time. That works out to 900 GB of bandwidth used to transfer these samples. If we still want these demos, they can be put on-line. If this is approved, I can make a sample index page for mozilla.org that these would be under, and change the debug menu to link to it. That's easy. Just give me the go-ahead.
Comment 1•22 years ago
|
||
This is not an installer decision. Easy enough to take out, just remove them in the package lists (as the Netscape installer does). Who wanted these in the first place? QA?
Assignee: dveditz → asa
Reporter | ||
Comment 2•22 years ago
|
||
Filed a bug for the menu/HTML work and assigned to myself. That should be done first, idealy. Setting dep.
Depends on: 156771
Comment 3•21 years ago
|
||
This patch removes res/samples and res/throbber - I hope. :-) Gerv
Comment 4•21 years ago
|
||
Comment on attachment 131361 [details] [diff] [review] Patch v.1 dveditz: could you review this? It would be good to save the space in the download, now we are using our own bandwidth. ;-) Gerv
Attachment #131361 -
Flags: review?(dveditz+bmo)
Comment 5•21 years ago
|
||
Comment on attachment 131361 [details] [diff] [review] Patch v.1 sr+r=dveditz if you also take these out of the os/2 package list
Attachment #131361 -
Flags: superreview+
Attachment #131361 -
Flags: review?(dveditz+bmo)
Attachment #131361 -
Flags: review+
Comment 6•21 years ago
|
||
Drat. I didn't notice the sr= mail :-( This'll be too late now. dveditz: I assume it's OK to do this on the trunk? Gerv
Comment 7•21 years ago
|
||
we have both r= and sr= can this get checked in?
pulling bug 107380 into this one, since the patch will solve both problems. can we get this checked in for 1.7? i'm hesitant to actually put a keyword down, but this would be worth doing, so that our primary branch builds don't have all this silly stuff still in it.
Component: Installer: XPI Packages → Build Config
Keywords: footprint
Summary: stop including res/samples in packages → stop including res/samples and res/throbber in packages
*** Bug 107380 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
Comment 11•20 years ago
|
||
we've had r and sr on this patch for over a year, and it still hasn't been checked in. is there a reason for this? i am hesitant about setting a blocking flag for a relatively minor issue like this one, but it is an easy fix that does provide some measurable benefit. anybody?
Comment 12•20 years ago
|
||
Attachment #171335 -
Flags: superreview?(dveditz)
Attachment #171335 -
Flags: review?(dveditz)
Comment 13•20 years ago
|
||
Comment on attachment 171335 [details] [diff] [review] Updated to the trunk, os/2 and static builds taken into account. packages-mac is no more. r/sr=dveditz
Attachment #171335 -
Flags: superreview?(dveditz)
Attachment #171335 -
Flags: superreview+
Attachment #171335 -
Flags: review?(dveditz)
Attachment #171335 -
Flags: review+
Comment 14•20 years ago
|
||
Checked in at Giacomo's request: Checking in packages-os2; /cvsroot/mozilla/xpinstall/packager/packages-os2,v <-- packages-os2 new revision: 1.71; previous revision: 1.70 done Checking in packages-static-unix; /cvsroot/mozilla/xpinstall/packager/packages-static-unix,v <-- packages-static-unix new revision: 1.81; previous revision: 1.80 done Checking in packages-static-win; /cvsroot/mozilla/xpinstall/packager/packages-static-win,v <-- packages-static-win new revision: 1.77; previous revision: 1.76 done Checking in packages-unix; /cvsroot/mozilla/xpinstall/packager/packages-unix,v <-- packages-unix new revision: 1.298; previous revision: 1.297 done Checking in packages-win; /cvsroot/mozilla/xpinstall/packager/packages-win,v <-- packages-win new revision: 1.282; previous revision: 1.281 done
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: Installer: XPI Packages → Installer
QA Contact: ktrina → general
You need to log in
before you can comment on or make changes to this bug.
Description
•