Closed Bug 1567543 Opened 5 years ago Closed 5 years ago

The direction of about:logins search text box is wrong

Categories

(Firefox :: about:logins, defect, P1)

Product:
Firefox
Component:
about:logins
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ehsan.akhgari, Assigned: jaws)

References

Details

(Keywords: rtl, Whiteboard: [skyline] [passwords:management])

Attachments

(2 files)

Screenshot
16.88 KB, image/png
Details
Bug 1567543 - Add dir=auto to the search box in about:logins so URLs will type correctly but this will also respect usernames which may not begin with a Latin character for example. r?sfoster
47 bytes, text/x-phabricator-request
Details | Review
Attached image Screenshot —

STR:

  1. In an RTL build, type "mozilla." inside the search box in about:logins.

See the screenshot.

We should probably use dir=auto for this textbox.

Priority: -- → P3
Whiteboard: [skyline] [password:management]
Whiteboard: [skyline] [password:management] → [skyline] [passwords:management]
Priority: P3 → P1
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f41622f9643
Add dir=auto to the search box in about:logins so URLs will type correctly but this will also respect usernames which may not begin with a Latin character for example. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/2f41622f9643

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1572696
Flags: qe-verify+

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20190918215055) (64-bit) and on the latest Firefox Beta 70.0b7 (Build ID: 20190916074538) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

  • The written string into the Search Bar has the correctly direction.
Status: RESOLVED → VERIFIED
status-firefox69: --- → disabled
status-firefox70: fixed → verified
status-firefox71: --- → verified
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
Flags: qe-verify+
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: