Closed Bug 1567546 Opened 5 months ago Closed 5 months ago

The direction of about:logins website address text is wrong

Categories

(Toolkit :: Password Manager, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- fixed

People

(Reporter: ehsan, Assigned: jaws)

References

()

Details

(Keywords: regression, rtl, Whiteboard: [passwords:management])

Attachments

(2 files)

STR:

  1. Open about:logins and look at an entry with a website address that ends in a slash.

See the screenshot.

We should probably use dir=auto here as well.

(In reply to :Ehsan Akhgari from comment #0)

STR:

  1. Open about:logins and look at an entry with a website address that ends in a slash.

Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?

See the screenshot.

The screenshot is missing.

Is this a regression compared to the old management UI: chrome://passwordmgr/content/passwordManager.xul ?

Flags: needinfo?(ehsan)
Whiteboard: [passwords:management]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Attached image Screenshot

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to :Ehsan Akhgari from comment #0)

STR:

  1. Open about:logins and look at an entry with a website address that ends in a slash.

Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?

This is not really true, the origin string can easily end with a slash, for example for "file://" origins.

See the screenshot.

The screenshot is missing.

Sorry about that, attaching it now.

Is this a regression compared to the old management UI: chrome://passwordmgr/content/passwordManager.xul ?

Yes. Years ago I fixed this same bug in the old UI in bug 478430.

Flags: needinfo?(ehsan)

(In reply to :Ehsan Akhgari from comment #3)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to :Ehsan Akhgari from comment #0)

STR:

  1. Open about:logins and look at an entry with a website address that ends in a slash.

Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?

This is not really true, the origin string can easily end with a slash, for example for "file://" origins.

Right, that is the only case I can think of and we already don't handle that properly in the list…

URL: file://
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b44d94036e69
Add dir=auto to the origin input in about:logins for improved RTL support. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
QA Whiteboard: [qa-70b-p2]
You need to log in before you can comment on or make changes to this bug.