1567546 - The direction of about:logins website address text is wrong

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[(no longer active)]

STR:

1. Open about:logins and look at an entry with a website address that ends in a slash.

See the screenshot.

We should probably use dir=auto here as well.

Comment 1

[Matthew N. [:MattN]]

(In reply to :Ehsan Akhgari from comment #0)

STR:

1. Open about:logins and look at an entry with a website address that ends in a slash.

Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?

See the screenshot.

The screenshot is missing.

Is this a regression compared to the old management UI: chrome://passwordmgr/content/passwordManager.xul ?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[(no longer active)]

Attachment: Screenshot

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to :Ehsan Akhgari from comment #0)

STR:

1. Open about:logins and look at an entry with a website address that ends in a slash.

Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?

This is not really true, the origin string can easily end with a slash, for example for "file://" origins.

See the screenshot.

The screenshot is missing.

Sorry about that, attaching it now.

Is this a regression compared to the old management UI: chrome://passwordmgr/content/passwordManager.xul ?

Yes. Years ago I fixed this same bug in the old UI in bug 478430.

Comment 4

[Matthew N. [:MattN]]

(In reply to :Ehsan Akhgari from comment #3)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to :Ehsan Akhgari from comment #0)

STR:

1. Open about:logins and look at an entry with a website address that ends in a slash.

Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?

This is not really true, the origin string can easily end with a slash, for example for "file://" origins.

Right, that is the only case I can think of and we already don't handle that properly in the list…

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1567546 - Add dir=auto to the origin input in about:logins for improved RTL support. r?sfoster

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b44d94036e69
Add dir=auto to the origin input in about:logins for improved RTL support. r=Gijs

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b44d94036e69