1567580 - [wpt-sync] Sync PR 17945 - [LargestContentfulPaint] Replace responseEnd with loadTime

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 17945 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17945
Details from upstream follow.

Nicolás Peña Moreno <[e-mail]> wrote:

[LargestContentfulPaint] Replace responseEnd with loadTime

This CL replaces responseEnd with loadTime. Before, responseEnd would be
used and would be problematic for memory cached images. We change it to
loadTime, the time at which LayoutObject::ImageNotifyFinished is called.
This time has the advantage of being independent of the memory cache and
being after the image has been appended to the DOM, as shown by a test.

To implement loadTime, we use a new HashMap. This HashMap populates the
timestamps that will be used in ImageRecords. We cannot use the existing
data structures because this happens before we know whether the image
will be added to the set of visible or invisible images, etc.

Bug: 982046, 965505
Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9
Reviewed-on: https://chromium-review.googlesource.com/1710682
WPT-Export-Revision: dc15759d237f20de4800bac603d7170fad32c4b3

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=668a0869bed5b540725a229e08fcc29a335cf8f1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3b1127bc68a4a1b6d0991eafdd7feb6c4f6f084

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=52a456e7cf073bbbe623ab45edba95b5468e064b

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c607e62f8fc970065f140b6cfa605f45d6ffa882

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad6011db700d122564a4050c4a214bae8dd2bc57

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e29c72575357d6755199833695f6c7f859885cd3

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dc5580b11d32359ab5c43e1f9a25dc6b04fa829

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 5 tests and 5 subtests
OK     : 5
FAIL   : 5

New tests that have failures or other problems:
/largest-contentful-paint/cross-origin-image.sub.html
    Cross-origin image is observable, with startTime equal to 0.: FAIL
/largest-contentful-paint/loadTime-after-appendChild.html
    Image loadTime occurs after appendChild is called.: FAIL
/largest-contentful-paint/observe-image.html
    Same-origin image is observable.: FAIL
/largest-contentful-paint/observe-text.html
    Element with elementtiming attribute is observable.: FAIL
/largest-contentful-paint/repeated-image.html
    Repeated image produces different timestamps.: FAIL

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3a3c6e2166468d11ff2d6a933028a1df3550caa

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78de7d7795a1
[wpt PR 17945] - [LargestContentfulPaint] Replace responseEnd with loadTime, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/80caf705bccc
[wpt PR 17945] - Update wpt metadata, a=testonly

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/78de7d7795a1
https://hg.mozilla.org/mozilla-central/rev/80caf705bccc