Closed Bug 1567580 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17945 - [LargestContentfulPaint] Replace responseEnd with loadTime

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17945 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17945
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

[LargestContentfulPaint] Replace responseEnd with loadTime

This CL replaces responseEnd with loadTime. Before, responseEnd would be
used and would be problematic for memory cached images. We change it to
loadTime, the time at which LayoutObject::ImageNotifyFinished is called.
This time has the advantage of being independent of the memory cache and
being after the image has been appended to the DOM, as shown by a test.

To implement loadTime, we use a new HashMap. This HashMap populates the
timestamps that will be used in ImageRecords. We cannot use the existing
data structures because this happens before we know whether the image
will be added to the set of visible or invisible images, etc.

Bug: 982046, 965505
Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9
Reviewed-on: https://chromium-review.googlesource.com/1710682
WPT-Export-Revision: dc15759d237f20de4800bac603d7170fad32c4b3

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 5 tests and 5 subtests
OK     : 5
FAIL   : 5

New tests that have failures or other problems:
/largest-contentful-paint/cross-origin-image.sub.html
    Cross-origin image is observable, with startTime equal to 0.: FAIL
/largest-contentful-paint/loadTime-after-appendChild.html
    Image loadTime occurs after appendChild is called.: FAIL
/largest-contentful-paint/observe-image.html
    Same-origin image is observable.: FAIL
/largest-contentful-paint/observe-text.html
    Element with elementtiming attribute is observable.: FAIL
/largest-contentful-paint/repeated-image.html
    Repeated image produces different timestamps.: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78de7d7795a1
[wpt PR 17945] - [LargestContentfulPaint] Replace responseEnd with loadTime, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/80caf705bccc
[wpt PR 17945] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/78de7d7795a1
https://hg.mozilla.org/mozilla-central/rev/80caf705bccc

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.