Closed Bug 1567681 Opened 2 years ago Closed 2 years ago

Port bug 1528614: Remove clickSelectsAll feature from textboxes

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Bug 1528614 removed the clickSelectsAll ability. We used it only on a few places which aren't very needed. Removing this should be no problem.

Alessandro, what do you think, is it okay to remove them without reinvent the functionality?

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9079560 - Flags: review?(alessandro)
Comment on attachment 9079560 [details] [diff] [review]
1567681-remove-clickSelectsAll.patch

Review of attachment 9079560 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think we can remove this option.
Having the entire string selected on a single click it's annoying sometimes, and since we're not using it consistently, it's better to remove it.

We're also getting rid of the textbox element, and I don't know if the clickSelectsAll would even work on a simple html:input.
Attachment #9079560 - Flags: review?(alessandro) → review+

Thanks.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9dc83f991206
Port bug 1528614: Remove clickSelectsAll feature from textboxes. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.