Closed
Bug 1567858
Opened 5 years ago
Closed 5 years ago
Mini-month must implement calIObserver
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 69.0
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(1 file)
1.89 KB,
patch
|
pmorris
:
review+
pmorris
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
I don't know why, but the mini-month has not been marked as implementing calIObserver, but it does. It's been this way since forever, but now that it's a custom element, I'm seeing "Component does not have requested interface" errors.
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #9079679 -
Flags: review?(paul)
Comment 2•5 years ago
|
||
Comment on attachment 9079679 [details] [diff] [review] 1567858-minimonth-caliobserver-1.diff Review of attachment 9079679 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Thanks for catching this.
Attachment #9079679 -
Flags: review?(paul) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/6abbce96d21c
Mark mini-month as implementing calIObserver; r=pmorris
Assignee | ||
Comment 4•5 years ago
|
||
Target 70 needed.
Flags: needinfo?(philipp)
Target Milestone: --- → 7.1
Comment 5•5 years ago
•
|
||
<Comment removed>
Updated•5 years ago
|
Target Milestone: 7.1 → 70
Updated•5 years ago
|
Flags: needinfo?(philipp)
Updated•5 years ago
|
Attachment #9079679 -
Flags: approval-calendar-beta?(philipp)
Comment 8•5 years ago
|
||
Comment on attachment 9079679 [details] [diff] [review] 1567858-minimonth-caliobserver-1.diff You should check necessary uplift upon review to avoid having to visit this another time.
Flags: needinfo?(paul)
Comment 9•5 years ago
|
||
Looks like this is fallout from bug 1534774, so it should go to 7.1 (beta).
Comment 10•5 years ago
|
||
Comment on attachment 9079679 [details] [diff] [review] 1567858-minimonth-caliobserver-1.diff Ok, I assume this is what I need to do. I know of no reason not to uplift.
Flags: needinfo?(paul)
Attachment #9079679 -
Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+
Comment 11•5 years ago
|
||
TB 69 beta 3 / Cal 7.1:
https://hg.mozilla.org/releases/comm-beta/rev/f0ec578d1c07ac3a724a4574546347edd62c4423
Flags: needinfo?(geoff)
Target Milestone: 70 → 7.1
You need to log in
before you can comment on or make changes to this bug.
Description
•