Make the inspector destruction codepath synchronous
Categories
(DevTools :: Inspector, enhancement)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(4 files)
See bug 1529621. This bug is dedicated to the Inspector and aims at getting rid of async on this particular method and all its dependencies:
https://searchfox.org/mozilla-central/rev/b9041f813de0a05bf6de95a145d4e25004499517/devtools/client/inspector/inspector.js#1562-1652
|
Assignee | |
Comment 1•5 years ago
|
||
See these two patches, but it looks like nothing is really async in inspector panel destruction codepath:
- get rid of ToolSideBar.destroy async:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=257834744&revision=1d3f5fded1bfe3342583b0afcc0115fe40b9dca2
It looks like there is some cruft here. It looks like we no longer use any iframe in sidebar... So we there is significant piece of code probably dead in this module and that would be nice to remove it. Also, it means that we no longer call each sidebar's panel's destroy method, should we fix that? - get rid of MarkupView.destroy async
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=257834744&revision=6a515588879f5b76d0a29c5c3c1da1dd59cec8e6
Nothing is async here.
If we combine these two patches we should be able to make the inspector destroy fully synchronous.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
This code in ToolSidebar.destroy looks dead as there shouldn't be any sidebar
loaded in distinct iframes anymore. So we are not trying to call sidebars destroy
from here anymore. Instead, it is being done from Inspector.destroy, via the _panels
Map.
|
|
Assignee | |
Comment 4•5 years ago
|
||
The fronts are destroyed when the toolbox closes and when a front is destroyed,
all its listeners are removed. So there is no real value in trying to unregister
them. On top of that, this destroy method is called by Inspector.destroy
and doesn't wait for its completion.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/321fa237ca12 Make the markup view destroy codepath synchronous. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/805fcf84f6ea Make the inspector sidebars destroy codepath synchronous. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/9c097465b2df Make changes view destroy codepath synchronous. r=rcaliman https://hg.mozilla.org/integration/autoland/rev/72b39fc80987 Make inspector panel's destroy synchronous. r=rcaliman
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/321fa237ca12
https://hg.mozilla.org/mozilla-central/rev/805fcf84f6ea
https://hg.mozilla.org/mozilla-central/rev/9c097465b2df
https://hg.mozilla.org/mozilla-central/rev/72b39fc80987
Description
•