Closed Bug 1567869 Opened 5 years ago Closed 5 years ago

Dark Theme: Unable to see when even lines are selected

Categories

(Thunderbird :: OS Integration, defect, P3)

Product:
Thunderbird
Component:
OS Integration
Platform:
Desktop
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1585765

People

(Reporter: boris, Unassigned)

References

Details

Attachments

(4 files)

The three mails are selected. Only the odd one appears in blue.
15.68 KB, image/png
Details
selection foreground
54.43 KB, image/jpeg
Details
selection background
32.83 KB, image/jpeg
Details
TB dark mode bug.png
59.12 KB, image/png
Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36

Steps to reproduce:

  • Activate Dark Theme (system-wide)
  • Go to Inbox
  • Select more than one email

Actual results:

  • Odd lines are selected in blue
  • Even lines are selected with absolutely no visual clue

Expected results:

  • All lines are selected in blue

There should be a difference between odd and even rows unless you use a userChrome.css which sets some sort of zebra-striping. Is that the case?

Flags: needinfo?(richard.marti)

Hi Jorg. No, I don't think I do, or not on purpose. How to check it?
I've cd to "~/Library/Thunderbird/Profiles/", then my profile, and there is no "chrome" folder, so I assume no userChrome.css, am I right?

Right. Let's see what our theme expert says.

Since it hasn't been verified that the reporter doesn't mean TB 60.8.0, and is actually using 68.0b(x).

Using TB 68.0b5 on Ubuntu 18.04.2 LTS I don't see any difference in rows with the Dark, Light or default themes.

With 3 messages selected they are all blue like the one selection in the reporters screenshot using the Light and Default themes.

With 3 messages selected using the Dark theme they are a light grey.

I don't see this issue with TB 68 and dark System theme.

What is weird, is that your selected rows are blue. With dark theme they have a partly transparent white.

I need correct infos about your TB: version (60.8 or 68), do you use a third party theme?

Flags: needinfo?(richard.marti) → needinfo?(boris)
  • Version : 68.0b5 (64-bit), mac OS 10.14.5 (18F132), installed through brew cask install thunderbird-beta
  • No add-on
  • Default theme switching to Black with the system

The only thing I added was the French spelling dictionary, I think.
If I enable the Dark Theme manually, I observe exactly the same behavior.

Flags: needinfo?(boris)

Strange, I don't know from where brew takes the binary. Can you try to download from here: https://www.thunderbird.net/en-US/channel/ No need to install it, double click inside the DMG should be enough.

Executed brew cask uninstall thunderbird-beta, then downloaded from your link: same behavior.

FYI, here's the cask for Thunderbird Beta, with the download URL: https://github.com/Homebrew/homebrew-cask-versions/blob/master/Casks/thunderbird-beta.rb

Sorry, I have to give up as I can't reproduce your issue. You don't have installed other extensions (except Lightning)?

I just completely uninstalled and reinstalled Thunderbird, loosing all my settings, just to start with a fresh install: always one blue line out of two when selecting all in the inbox.

However, when I go to the "Sent" folder, I get the gray selecting cue as described by :walts48 !

New info: this kind of display only happens with IMAP mail accounts. If I configure a POP account, I also have the grey lines in Inbox.

Interesting, IMAP may have additional selectors, ... and we're likely to test more on local folders.

It's a IMAP account too and it looks correct here.

I switch to "Unified" folders option in view, and now I have the good display on the unified inbox.
If I go to a blue folder in one of the accounts, I have the bad display.
It's as if there are two kinds of folders : mapped ones, with the bad display, and thunderbird ones, with the good display. I don't know if that makes any sense.

My tests where already with a not unified setting. I re-tested and still can't see it.

Alessandro, could you try it on your Mac?

Flags: needinfo?(alessandro)

I can't test this for now as my mac has been recalled for battery replacement, sorry.

Flags: needinfo?(alessandro)

Sorry for the duplicate bug report. I had quite different search terms and always included macOS so the search did not show me this bug.

I can confirm that I have this issue with the release version 68.0 for macOS downloaded directly from thunderbird.net
I can also confirm that this only happens in IMAP folders and not in a POP inbox.
When I select "View" -> "Folders" -> "All" (usually I use the "Unified" setting) and select some messages I get a weird mixture of some messages showing the light grey highlight, some messages show the system-wide highlight colour and some messages do not highlight at all.

Following both comment 0 and comment 19 I have been unable to replicate the issue on Linux VIA the Gnome Desktop on either 68.0 or 69.0b4.

Setting as New thanks to Martin's verification in the last comment before mine.

Severity: normal → minor
Status: UNCONFIRMED → NEW
Type: enhancement → defect
Component: Untriaged → OS Integration
Ever confirmed: true
OS: Unspecified → macOS
Priority: -- → P3
Hardware: Unspecified → Desktop

Tested again on macOS 10.14 with dark system theme and TB 68 on a IMAP folder. All messages are correctly highlighted. Also started multiple times and switched the folder, always correct highlighting.

Attached image selection foreground —
Attached image selection background —

Did some clean testing on macOS 10.14.6.
Created a fresh OS user to rule out any leftover settings in Thunderbird.
Added a single IMAP account.
Bug is immediately visible when TB is in foreground (see 'selection foreground' attachment).
When the TB window is in the background it changes to what I assume is expected (see 'selection background' attachment).
One thing that I can think of which might be different in my setup compared to others testing here is that my system is running with German language settings and thus TB is showing a German UI.

My system is running with German locale too.

French locale here, same issue and same presentation than @martin.weiser.

I am seeing this bug as well. USA. TB 58.1.1 64-bit - When Mac is in "dark mode" the highlight in the inbox only shows for every other message.

I can cursor down through the message and on every other one I can't tell where the highlight is. If I use Cmd-A to highlight all message, only half are highlighted, skipping one in between each message.

I have no ccs files in use and no extensions other than Lightning which came with TB, and am using the default theme.

Switching the Mac back to light appearance makes the problem go away. So now I am forced to use it.

I don't see a way to attached a screenshot here.

Attached image TB dark mode bug.png —

found the attachments. here's the bug on my system.
I only installed TB yesterday so it's super fresh.

See Also: → 1588000
See Also: → 1585765

Let's bundle the issues in bug 1585765.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
See Also: 1585765 →
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: