Closed Bug 1567894 Opened 5 months ago Closed 5 months ago

Do not restrict the GeckoView/Glean SDK mapping to a single category

Categories

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Dexter, Assigned: Dexter)

References

(Blocks 1 open bug)

Details

(Whiteboard: [telemetry:glean-rs:m7])

Attachments

(1 file)

As it is currently implemented and discussed here, the GeckoView mapping function will be generated once per each category (each .kt file). This forces us to use a single category in the adapter that will be created as part of bug 1566374.

There's at least two options to enable a "global mapping":

  • generated the mapping of Gecko metrics in a single Kotlin file/class separate from the metrics objects, to only have one. And these will generally live in engine-gecko where we can add the single line necessary to init them. We'd need a separate template just for this, and that template will have to import all of the metric instances from other files.
  • There is sealedSubclasses, which lets you iterate over all subclasses of a sealed class. You could then make a base class that all of the Gecko mappings would inherit from, and then I think you could iterate over all of them to perform the lookup.
Blocks: 1566340
Depends on: 1566356
Priority: -- → P3
Whiteboard: [telemetry:glean-rs:m?]
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:m8]
Assignee: nobody → alessio.placitelli
Priority: P3 → P1
Whiteboard: [telemetry:glean-rs:m8] → [telemetry:glean-rs:m7]
Attached file GitHub Pull Request

This was just merged and a release was cut: v0.34.0.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.