Closed Bug 156792 Opened 18 years ago Closed 12 years ago

More Information button does not belong in preferences (it should be a link)

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Unassigned)

References

Details

Attachments

(2 files, 3 obsolete files)

1This is how you can tell a button doesn't belong in a pref window:
(from help for the pref window)

Navigator Preferences - Smart Browsing
    * Internet Keywords:
          o Enable Internet Keywords: Select this to enable fast access to services such as stock quotes, search, and other information from the Location bar.
          o More Information: Click this to learn more about using Internet Keywords.

What you have: text which explains that clicking a button will get you information about internet keywords.
What you should have: a link to more information about internet keywords. And *NO* button in the prefs dialog.
Attached patch proposal (obsolete) — Splinter Review
putting js into help is probably bad, we probably need a generic system for
this.
Mass reassign of my non-Firefox bugs to ben_seamonkey@hotmail.com
Assignee: bugs → ben_seamonkey
Assignee: ben_seamonkey → neil.parkwaycc.co.uk
Comment on attachment 90867 [details] [diff] [review]
proposal

You don't need region-specific code in help, it's already localized. Just link
directly to the page, possibly with a localization note.
Alternatively make the smart browsing URL an entity in region.dtd and turn the
button into a link like the Get New Themes link.
Attachment #90867 - Flags: review-
Timeless, how about updating your patch to meet Neil's comments?

Thanks,

Prog.
Summary: More Information button does not belong in preferences → More Information button does not belong in preferences (it should be a link)
I like the button style because it gives end users a sense that the pref UI is
not the same as documents they view, but I really don't care too much. I'd
rather have Mozilla be clean than overly end-user focused, that is Firefox's
function.

(In reply to comment #5)
> I like the button style because it gives end users a sense that the pref UI is
> not the same as documents they view,

How can one mistake the Preferences for a document? It can only be opened
intentionally, when one consciously chooses to change prefs.

> I'd rather have Mozilla be clean than overly end-user focused, that is 
> Firefox's function.

A clean UI has to also be consistent, right? So, would you change
Appearance/Themes/Get-New-Themes to a button instead of a link?

Prog.
Since I'm updating help file this involves I attach an updated & modified
version of timeless patch. I agree with timeless - the button shouldn't be
there. There is already a help button. It's better to have links to info about
Internet Keywords and Domain Guessing in the help file. This patch is basically
an update of timeless old patch, with a few exceptions:

1) Removes smartBrowsingURL from region.properties as well

2) Lacks the changes made in the help file. They will be done after this patch
has gotten + or - (since this is just a proposal).
Attachment #90867 - Attachment is obsolete: true
Comment on attachment 154396 [details] [diff] [review]
Update of timeless removal of the button

Neil, can you give me your opinion, please?
Attachment #154396 - Flags: review?(neil.parkwaycc.co.uk)
Attached patch Changes in help file (obsolete) — Splinter Review
Here's a patch that covers the changes in the help file. This patch also adds
some lines about Domain Guessing and a link to the mozilla.org doc about domain
guessing.
Attachment #154470 - Flags: review?(rlk)
Comment on attachment 154470 [details] [diff] [review]
Changes in help file

Oops, I see some errors the patch. Will come up with a better one.
Attachment #154470 - Attachment is obsolete: true
Attachment #154470 - Flags: review?(rlk)
Attachment #154475 - Flags: review?(rlk)
Comment on attachment 154475 [details] [diff] [review]
Changes in the help file - better patch

r=rlk@trfenv.com with the attachment above checked in.
Attachment #154475 - Flags: review?(rlk) → review+
Attachment #154396 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #154396 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #154396 - Flags: review?(jag)
Comment on attachment 154396 [details] [diff] [review]
Update of timeless removal of the button

rs=me for the /toolkit change.
Comment on attachment 154396 [details] [diff] [review]
Update of timeless removal of the button

I don't see any changes to the .dtd here. While you're there, I think the
description should be extended to refer to the help, preferably not as corny as
"For more information, see Help."
Attachment #154396 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview-
> I don't see any changes to the .dtd here.

Sorry about that!

> While you're there, I think the
> description should be extended to refer to the help, preferably not as
> corny as "For more information, see Help."

Hmm, there is already a Help button and I don't recall any other references
like that in the other prefwindows. Wouldn't it look a bit odd? I mean, isn't
it obvious that clicking the Help button will tell the user more about Internet
Keywords and Domain Guessing?
Attachment #154396 - Attachment is obsolete: true
Attachment #156284 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #156284 - Flags: review?(jag)
Attachment #154396 - Flags: review?(jag)
Comment on attachment 156284 [details] [diff] [review]
New version of timeless patch with changes in the .dtd file

So this just removes the "More Information" from the pref window. Hmmm...

It'd be nice if there were just a link ("Tell me more") to the web-page in the
preference panel itself, it's an interface the user is familiar with, and the
themes panel uses it to direct the user to new themes.

If we put that link in the help page, and optionally add a hint like "see help
for more" (but less corny), I think that extra level of indirection is kinda
silly.

Also, that web page is being the "help" for that feature, more so than the help
page, which just restates what the description says.
> It'd be nice if there were just a link ("Tell me more") to the web-page in the
> preference panel itself, it's an interface the user is familiar with, and the
> themes panel uses it to direct the user to new themes.

In that case there should be two "tell me more"-links -- there are now two
webpages: One for Internet Keywords and one for Domain Guessing (see the help
file patch, http://bugzilla.mozilla.org/attachment.cgi?id=154475&action=view). I
just thought since we actually have a help viewer it feels kind of odd to have 
links or buttons in the prefs window to external "help" documents.


btw, i removed some "." from the text to the right of the checkboxes. That
appeared to be in order with most of the other prefwindows.
Product: Browser → Seamonkey
Attachment #156284 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #156284 - Flags: review?(jag)
No comment in 3½ years. In the mean time, Sm-trunk preferences UI have started being ported to a new backend.

Resetting A+QA -- feel free to "accept" (or re-accept) if you want to work on this.
Assignee: neil → nobody
QA Contact: bugzilla → prefs
I fixed this in bug 411226.
Status: NEW → RESOLVED
Closed: 12 years ago
Depends on: 411226
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.