Closed Bug 1567929 (uj-mc-phab-integration) Opened 4 months ago Closed 3 months ago

automatically run activity-stream repo unit tests on phabricator patches touching that code

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- fixed

People

(Reporter: dmose, Assigned: dmose)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

This may just be putting together a try server preset; need to chat with jlast about where devtools is on this.

Priority: -- → P2

We should be able to get them to run automatically with a simple change to node.yml analogous to this: https://hg.mozilla.org/mozilla-central/rev/50a04d79f020.

Then, after the build runs, people can look at the "Treeherder Jobs" link on the Phabricator review page to see whether it's all green or not.
Which is equivalent to what the debugger has today.

There are two other developer ergonomics pieces that we'll want to do in the future, and one (or maybe both) are blocked on build-system
changes:

  • improve latency time before phabricator unit test runs complete, by deciding what tradeoffs we're willing to live with to avoid forcing a full-build each time the unit-tests are run
  • make the unit-tests automatically report any failure changes back to main phabricator review page so that people don't have to go look at the "Treeherder Jobs" by hand

I'll spin off separate bugs for these.

Attachment #9089079 - Attachment description: Bug 1567929 - enable newtab/messaging unit test builds for phab code review, r?Bastien → Bug 1567929 - enable newtab/messaging unit test builds for phab code review
Pushed by dmosedale@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cbc4579e85a
enable newtab/messaging unit test builds for phab code review r=bastien
Summary: make it easy/automatic to run activity-stream repo unit tests on phabricator pushes → automatically run activity-stream repo unit tests on phabricator pushes touching that code
Summary: automatically run activity-stream repo unit tests on phabricator pushes touching that code → automatically run activity-stream repo unit tests on phabricator patches touching that code
Priority: P2 → P1
Assignee: nobody → dmose
Iteration: --- → 70.4 - Aug 19 - Sep 1
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

(In reply to Dan Mosedale (:dmose, :dmosedale) from comment #1)

There are two other developer ergonomics pieces that we'll want to do in the future:

  • improve latency time before phabricator unit test runs complete, by deciding what tradeoffs we're willing to live with to avoid forcing a full-build each time the unit-tests are run

Bug 1579154

  • make the unit-tests automatically report any failure changes back to main phabricator review page so that people don't have to go look at the "Treeherder Jobs" by hand

Bug 1579162

You need to log in before you can comment on or make changes to this bug.