automatically run activity-stream repo unit tests on phabricator patches touching that code
Categories
(Firefox :: Messaging System, task, P3)
Tracking
()
People
(Reporter: dmosedale, Assigned: dmosedale)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
Attachments
(1 file)
This may just be putting together a try server preset; need to chat with jlast about where devtools is on this.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
We should be able to get them to run automatically with a simple change to node.yml analogous to this: https://hg.mozilla.org/mozilla-central/rev/50a04d79f020.
Then, after the build runs, people can look at the "Treeherder Jobs" link on the Phabricator review page to see whether it's all green or not.
Which is equivalent to what the debugger has today.
There are two other developer ergonomics pieces that we'll want to do in the future, and one (or maybe both) are blocked on build-system
changes:
- improve latency time before phabricator unit test runs complete, by deciding what tradeoffs we're willing to live with to avoid forcing a full-build each time the unit-tests are run
- make the unit-tests automatically report any failure changes back to main phabricator review page so that people don't have to go look at the "Treeherder Jobs" by hand
I'll spin off separate bugs for these.
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
|
||
bugherder uplift |
Assignee | ||
Comment 6•5 years ago
|
||
(In reply to Dan Mosedale (:dmose, :dmosedale) from comment #1)
There are two other developer ergonomics pieces that we'll want to do in the future:
- improve latency time before phabricator unit test runs complete, by deciding what tradeoffs we're willing to live with to avoid forcing a full-build each time the unit-tests are run
- make the unit-tests automatically report any failure changes back to main phabricator review page so that people don't have to go look at the "Treeherder Jobs" by hand
Comment 7•5 years ago
|
||
Backed out changeset 2cbc4579e85a (bug 1567929) for causing Bug 1597457 at ANdi's request. a=backout
Backout link: https://hg.mozilla.org/mozilla-central/rev/507ec3d5394ab4e4576c9fe2eb87086f0297e4ae
Comment 8•5 years ago
|
||
Second backout for the same issue: https://hg.mozilla.org/mozilla-central/rev/4ca097f5364361681870b5aff9dd1102fb07153f
Updated•5 years ago
|
Comment 9•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dmose, could you have a look please?
For more information, please visit auto_nag documentation.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 10•4 years ago
|
||
This patch can reland once we fix bug 1579162 by doing something that doesn't do PGO builds (ie normal optimized builds should be just fine). Probably the first thing to do is for sometime to see bug 1579162 is still a problem, as it's conceivable that the "use PGO" behavior is no longer an issue (though I suspect it is).
Updated•2 years ago
|
Description
•