1567932 - [project-config] add an [excludes] instruction

Status: RESOLVED FIXED

(Localization Infrastructure and Tools :: compare-locales, enhancement)

Description

[Axel Hecht [:Pike]]

When splitting up localization work between a default config, and an exception config suite, it'd be nice to define the default by:

[[excludes]]
  path = "exception-config.toml"

This is easy to write down in toml, and it allows for config changes to be done in the exception config suite, w/out having to manage the opposite by defining inclusive rules.

How to actually implement this, not exactly as easy ;-)

Comment 1

[Axel Hecht [:Pike]]

I'm only going to add minimal support right now. In particular, I'm not going to support excludes inside excludes. I don't want to wrap my brain around that unless it's necessary. And it might only be implementable with a rather deep refactor.

Comment 2

[Axel Hecht [:Pike]]

Attachment: Bug 1567932, support [[excludes]] as top-level item in project config, r=stas

This allows for project configs to exclude other project configs.
This is now allowing for excludes to be in children or in other excludes.

Comment 3

[Axel Hecht [:Pike]]

pmac, can I get your review on this? I figured getting your review on this would get your feet wet on the technical details, and also set precise expectations on what's implemented.

There's one specific module here, mozpath, which is basically os.path with / as path separator, also on Windows. I took this from the Firefox build system, it makes matching path patterns a lot easier.

Comment 4

[Paul [:pmac] McLanahan]

I'll take a look. Never used Phabricator before, but it looks easy enough. Thanks for the ping. Leaving the NI so I won't forget.

Comment 5

[Paul [:pmac] McLanahan]

Review is submitted.

Comment 6

[Axel Hecht [:Pike]]

https://hg.mozilla.org/l10n/compare-locales/rev/cb6b6ea4e2f5e49f567230f3e26b918453ce06ea landed, marking FIXED.