Closed
Bug 1567944
Opened 5 years ago
Closed 5 years ago
remove some MSVC pragma warning bits
Categories
(Core :: MFBT, task)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(2 files)
...which clang-cl doesn't support.
|
Assignee | |
Comment 1•5 years ago
|
||
We don't support MSVC anymore, and clang-cl just ignores these pragmas.
|
|
Assignee | |
Comment 2•5 years ago
|
||
We don't support MSVC anymore, clang-cl ignores these pragmas, and
nobody actually used the macros anyway.
Depends on D38887
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd3decf2c1d4 remove MSVC-specific warning goo from {Vector,Span}.h; r=dmajor https://hg.mozilla.org/integration/autoland/rev/04b82bfc269e remove *DISABLE_INTEGRAL_CONSTANT_OVERFLOW_WARNING macros; r=dmajor
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/cd3decf2c1d4
https://hg.mozilla.org/mozilla-central/rev/04b82bfc269e
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•