1567950 - remove `full` as a value from `MOZ_LTO`

Status: RESOLVED INVALID

(Firefox Build System :: General, task)

Description

[Nathan Froyd [:froydnj]]

I don't think we're really planning on using this...unless we wanted to keep full around for GCC (and disallow thin when using GCC)? But GCC-style LTO currently works with either full or thin, so I doubt anybody is explicitly using full.

Comment 1

[Mike Hommey [:glandium]]

I think at least Fedora does. Martin, do you confirm?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Hi,

Fedora does not explicitly set that, we use only:

ac_add_options MOZ_PGO=1
ac_add_options --enable-lto

and also set g++ as a compiler by:

export CC=gcc
export CXX=g++
export AR="gcc-ar"
export NM="gcc-nm"
export RANLIB="gcc-ranlib"

Comment 3

[Mike Hommey [:glandium]]

FWIW, Gentoo did, but that changed recently-ish: https://gitweb.gentoo.org/repo/gentoo.git/commit/www-client/firefox?id=2f69a379837e7e98639b4349450bbc025e925cc0

Comment 4

[[:sergesanspaille]]

And we know use it in our shippable (through "full,cross") builds since Bug 1834815, so definitively useful.