Convert event listener tree to a true tree component with correct keyboard navigation
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: Harald, Unassigned)
References
(Blocks 1 open bug)
Details
What were you doing?
- Navigate Event Listener BP with keyboard
What happened?
Tabs switch between arrow icons and checkboxes.
Tabbing through Debugger takes a lot longer with the many tab-targets that the Events panel includes.
What should have happened?
Tab into panel, then use tree-navigation (arrow/enter/space to) navigate and checl.
Currently the arrows (left/right and up/down) scroll the viewable area of the pane, which can be helpful if the window has been shrunk down. I agree tabbing through all the targets in this panel is tedious, but I wonder if it's necessary/desirable to disable this behavior of the arrow keys in order to use them for navigation within the panel? In the Sources panel the arrow keys work for navigation, meaning arrow keys behave differently in various debugger panes.
|
Reporter | |
Comment 2•7 years ago
|
||
Currently the arrows (left/right and up/down) scroll the viewable area of the pane, which can be helpful if the window has been shrunk down.
I can see your point, Alex. The trade off would be scrolling vs the impact of trapping the tab focus with too many targets. I have not seen other trees in DevTools or Firefox that don't have .
Cmd-Up/Down also scrolls, similar to page up/down on Windows. Related, hopefully users don't have to scroll through the whole list when filtering landed in bug 1567966.
|
||
Comment 3•6 years ago
|
||
I'm looking for a good first bug and I would like to work on this one.
|
|
Reporter | |
Comment 4•6 years ago
|
||
David, would you be up for mentoring?
|
|
||
Comment 5•6 years ago
|
||
Hello and welcome Alex! This one is going to be fairly complex so I don't think it's a great first bug. After you get a bit more experience I'd love to mentor you through it!
|
||
Comment 6•6 years ago
|
||
Hey, can I help with this, I have submitted patches for 2 bugs and would like to help with a more complex bug.
|
|
||
Comment 7•6 years ago
|
||
Sure David, that sounds like a plan. In the meantime I'll look for some other bug to work on.
|
|
||
Comment 8•6 years ago
|
||
Awesome Manish! Check out our ManagedTree component, which uses Tree -- that's the best way to get started!
Hello, if no one is working on this bug, I would like to address it, can I proceed ?
|
||
Comment 11•6 years ago
|
||
Thanks, David. I will let you know if faced any issue.
|
||
Updated•5 years ago
|
|
||
Updated•3 years ago
|
Description
•