Open Bug 1568027 Opened 6 years ago Updated 1 year ago

WebRender performs worse on Binding of Isaac CodePen demo (svg filters/blob)

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

Project Flags:
Performance Impact medium

People

(Reporter: mconley, Unassigned, NeedInfo)

References

(Depends on 1 open bug, Blocks 2 open bugs,
URL
)

Details

(Keywords: perf:responsiveness)

Original tweet: https://twitter.com/chriscoyier/status/1153400105711460352

I've forked the CodePen - here it is: https://codepen.io/anon/pen/RXWzbW

Let me capture some profiles real quick.

WebRender enabled: https://perfht.ml/2Y6kjxF

Actually, I was wrong - disabling WebRender on my Windows device improved the performance here considerably.

WebRender disabled: https://perfht.ml/2YcItqF

Summary: Binding of Isaac CodePen demo causes Firefox to choke with and without WebRender enabled → Binding of Isaac CodePen demo causes Firefox to choke with WebRender enabled
Summary: Binding of Isaac CodePen demo causes Firefox to choke with WebRender enabled → WebRender performs worse on Binding of Isaac CodePen demo
Component: Graphics → Graphics: WebRender
Depends on: wr-perf
Priority: -- → P3
Summary: WebRender performs worse on Binding of Isaac CodePen demo → WebRender performs worse on Binding of Isaac CodePen demo (svg filters/blob)

The WebRender profiles

Depends on: wr-svg-filter-perf

:jrmuizel, your comment is a bit vague :)

Flags: needinfo?(jmuizelaar)
Whiteboard: [qf] → [qf:p2:responsiveness]

Let me try again. The WebRender profiles don't show the WebRender threads. Adding "RenderBackend,Renderer,WebRender,Wr" to the thread list will give more useful results.

Flags: needinfo?(jmuizelaar) → needinfo?(mconley)

Sure thing:

https://perfht.ml/2YuRn2H

Flags: needinfo?(mconley) → needinfo?(jmuizelaar)

Super slow blob rasterization caused by a lot of filters. This should get better as we move more SVG filters to WebRender.

Blocks: wr-svg-filter-perf
No longer depends on: wr-svg-filter-perf

I can still reproduce this slowness on v96. It becomes much more noticeable when the full view is chosen.
https://codepen.io/DavidJAldred/full/WqLxme

Performance Impact: --- → P2
Keywords: perf:responsiveness
Whiteboard: [qf:p2:responsiveness]
Severity: normal normal → S3 S3
No longer depends on: wr-perf

Profile: https://share.firefox.dev/3MP3gfC
Still stuttery.

This filter graph uses one filter that is not accelerated yet (feSpecularLighting), it depends on Bug 1896740.

Depends on: 1896740
You need to log in before you can comment on or make changes to this bug.