1568108 - Popup blocker sub-item in the identity popup should be indented

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Johann Hofmann [:johannh]]

Attachment: Screenshot 2019-07-22 at 14.56.08.png

It's supposed to look like below. This was caused by bug 1501991 adding 12px extra padding to the permission icons without considering the arrow.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95591b5b87ca
Indent popup sub-item in the identity popup. r=pbz

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/95591b5b87ca

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Looks like a pretty safe patch to uplift. Did you want to nominate it for Beta & ESR68 approval?

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz

Beta/Release Uplift Approval Request

• User impact if declined: Slight style regression in the identity popup that makes it less clear that the popup-subitem belongs to its parent.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: - Open a blocked popup

• Click on the identity block to open the identity panel
• The permissions section should look like it's shown in comment 0

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple front-end patch that mostly updates styles
• String changes made/needed: None

Comment 6

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0b8.
Fix verified with 70.0a1 (2019-07-28) .

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz

Simple UI clean-up. Approved for 69.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee661cec4188

Comment 9

[Cristian Fogel [:cfogel]]

Fix verified with 69.09 on Windows 10, macOS 10.13, Ubuntu 16.04.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Hi Johann, did you want to nominate this for ESR68 approval too?

Comment 11

[Johann Hofmann [:johannh]]

Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Low risk patch that polishes permissions UI
• User impact if declined: Slight style regression in the identity popup that makes it less clear that the popup-subitem belongs to its parent.
• Fix Landed on Version: 69 & 70
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple front-end patch that mostly updates styles
• String or UUID changes made by this patch: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz

Minor UI fixup. Approved for 68.1esr.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/698d088d135c