1568119 - Setup OOM simulation testing for MarkPagesInUse

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Paul Bone [:pbone]]

Bug 1564674 makes MarkPagesInUse fallible. Should we setup OOM simulation testing for it? How?

Comment 1

[Jon Coppeard (:jonco)]

(In reply to Paul Bone [:pbone] from comment #0)

Bug 1564674 makes MarkPagesInUse fallible. Should we setup OOM simulation testing for it? How?

You can add | if (js::oom::ShouldFailWithOOM()) { return false; } | to the start of the function. Then write a test case that causes this function to be called and run it via oomTest(), like this:

https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/gc/bug-1238575-2.js

These tests can take a long time to run so it worth trying to find a minimal test case.

Comment 2

[Jon Coppeard (:jonco)]

(In reply to Jon Coppeard (:jonco) from comment #1)
Oh, also it depends on what you do if this fails. It you crash then we can't OOM test it because we don't catch crashes.

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1568119 - Setup OOM simulation testing for MarkPagesInUseHard r=jonco

There are three cases where this function could OOM:

• Zeal mode - we want to crash if this OOMs
• Growing the Nursery - We've added a new test to exercise this code path
• Disabling the Nursery - Plenty of existing tests seem to cover this
  with OOM testing.

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1568119 - Remove a superflous assert r=jonco

Depends on D39457

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9abaa7c7e58
Setup OOM simulation testing for MarkPagesInUseHard r=jonco
https://hg.mozilla.org/integration/autoland/rev/5f39bfa28b4d
Remove a superflous assert r=jonco

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1568119 - Mark the test as slow so it doesn't cause timeouts r=nbp

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0abde41f3403
Mark the test as slow so it doesn't cause timeouts r=nbp

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c9abaa7c7e58
https://hg.mozilla.org/mozilla-central/rev/5f39bfa28b4d
https://hg.mozilla.org/mozilla-central/rev/0abde41f3403

Comment 9

[Jon Coppeard (:jonco)]

(In reply to Pulsebot from comment #7)
Replacing calls to 'gc()' with 'minorgc()' might speed the test up.

Comment 10

[Paul Bone [:pbone]]

Good idea, (Bug 1570216)