1568136 - Call gfxUtils::RemoveShaderCacheFromDiskIfNecessary() in gfxPlatform::InitWebRenderConfig()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Sotaro Ikeda [:sotaro]]

gfxUtils::RemoveShaderCacheFromDiskIfNecessary() is called before gfxPlatform::InitWebRenderConfig(). It is not good. By it, obsoleted program binary might be used after Firefox update.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1568136 - Call gfxUtils::RemoveShaderCacheFromDiskIfNecessary() in gfxPlatform::InitWebRenderConfig()

Comment 2

[Jamie Nicol [:jnicol]]

I've noticed some "failed to compile shader" log messages on my android devices, and can confirm that this is the cause, and your patch fixes it. Hopefully this will fix bug 1567620 too.

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=626a2c646d8c1fc135772a6d4806babea62dff85

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/920ff23dbffc
Call gfxUtils::RemoveShaderCacheFromDiskIfNecessary() in gfxPlatform::InitWebRenderConfig() r=nical

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/920ff23dbffc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance. IIUC, we don't need this on ESR68 since WebRender is disabled there.

Comment 7

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9079942 [details]
Bug 1568136 - Call gfxUtils::RemoveShaderCacheFromDiskIfNecessary() in gfxPlatform::InitWebRenderConfig()

Beta/Release Uplift Approval Request

• User impact if declined: Obsoleted shader program could continue to exist in a disk cache and could be loaded. It could cause a problem like Bug 1567620 if the program is obsoleted by graphics driver update. But if the program is obsoleted by WR shader change, the program is loaded, but it is not used by WR, since different program uses different digest(file name).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change reverts to before Bug 1546901 fix.
• String changes made/needed: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9079942 [details]
Bug 1568136 - Call gfxUtils::RemoveShaderCacheFromDiskIfNecessary() in gfxPlatform::InitWebRenderConfig()

Fixes running a stale shader program in some situations when WebRender is enabled, which can cause badness. Approved for 69.0b8.

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca01f1172272

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out as https://hg.mozilla.org/releases/mozilla-beta/rev/8e7930ac68068cae158a94f154c46db2bb529bfc and relanded with correct commit information: https://hg.mozilla.org/releases/mozilla-beta/rev/53bb71da50e59d953cdcd68a29c5afabd160abfc